Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import stdlib ABCs from 'collections.abc' rather than 'collections'. #6451

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Import stdlib ABCs from 'collections.abc' rather than 'collections'. #6451

merged 1 commit into from
Nov 12, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 8, 2018

On Python 2.7, fall back to 'collections'.

Closes #6450.

@tseaver tseaver added api: bigquery Issues related to the BigQuery API. api: core api: firestore Issues related to the Firestore API. type: cleanup An internal cleanup or hygiene concern. labels Nov 8, 2018
@tseaver tseaver requested review from theacodes and crwilcox November 8, 2018 18:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2018
On Python 2.7, fall back to 'collections'.

Closes #6450.
@tseaver tseaver merged commit f99f625 into googleapis:master Nov 12, 2018
@tseaver tseaver deleted the 6450-api_core-core-bigquery-firestore-py38-collections branch November 12, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. api: core api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants