Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deleting blob when it's renamed to itself #6347

Closed
wants to merge 1 commit into from
Closed

Avoid deleting blob when it's renamed to itself #6347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion storage/google/cloud/storage/bucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,8 @@ def rename_blob(self, blob, new_name, client=None):
If :attr:`user_project` is set, bills the API request to that project.

Effectively, copies blob to the same bucket with a new name, then
deletes the blob.
deletes the blob. In case the new and old names are the same, the blob
is returned without any operations occurring.

.. warning::

Expand All @@ -926,6 +927,9 @@ def rename_blob(self, blob, new_name, client=None):
:rtype: :class:`Blob`
:returns: The newly-renamed blob.
"""
if blob.name == new_name:
return blob

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

new_blob = self.copy_blob(blob, self, new_name, client=client)
blob.delete(client=client)
return new_blob
Expand Down