Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS: Fix copy-pasta from datastore README. #6208

Merged
merged 1 commit into from
Oct 15, 2018
Merged

DNS: Fix copy-pasta from datastore README. #6208

merged 1 commit into from
Oct 15, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 15, 2018

Closes #6205.

@tseaver tseaver added the api: dns Issues related to the Cloud DNS API. label Oct 15, 2018
@tseaver tseaver requested a review from crwilcox as a code owner October 15, 2018 15:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 15, 2018

Trivial docs-only fix -- merging without review.

@tseaver tseaver merged commit f8d2e3d into googleapis:master Oct 15, 2018
@tseaver tseaver deleted the 6205-dns-fix_datastore_copy_pasta branch October 15, 2018 15:55
econchick
econchick reviewed Oct 16, 2018
View reviewed changes
dns/README.rst
@@ -30,7 +30,7 @@ In order to use this library, you first need to go through the following steps:

.. _Select or create a Cloud Platform project.: https://console.cloud.google.com/project
.. _Enable billing for your project.: https://cloud.google.com/billing/docs/how-to/modify-project#enable_billing_for_a_project
.. _Enable the Google Cloud Datastore API.: https://cloud.google.com/datastore
.. _Enable the Google Cloud Datastore API.: https://cloud.google.com/dns

This comment was marked as spam.

Sign in to view

tseaver added a commit that referenced this pull request Oct 17, 2018
@tseaver
Fix 'Datastore' in text as well as examples / links
0ccd143 
Follow on to #6208.
@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

@econchick Thanks for the catch! 0ccd143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@econchick econchick econchick left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @econchick @googlebot