Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: add destination table properties to 'LoadJobConfig'. #6202

Merged
merged 26 commits into from
Oct 17, 2018
Merged

BigQuery: add destination table properties to 'LoadJobConfig'. #6202

merged 26 commits into from
Oct 17, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 12, 2018

Closes #5093.

This PR includes a bunch of new explicit unit test cases / assertions for LoadJobConfig, and reorders the properties alphabetically, to make it easier to match up with the docs.

/cc @yiga2.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Oct 12, 2018
@tseaver tseaver requested a review from tswast October 12, 2018 22:37
@tseaver tseaver requested a review from crwilcox as a code owner October 12, 2018 22:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2018
tswast
tswast approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bigquery/google/cloud/bigquery/job.py Outdated Show resolved Hide resolved
bigquery/tests/unit/test_job.py Outdated Show resolved Hide resolved
@tseaver tseaver removed the request for review from crwilcox October 17, 2018 02:01
@tseaver tseaver mentioned this pull request Oct 17, 2018
Closed
@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Oct 17, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

Merge blocked pending resolution of #6231, and a re-run of the Kokoro Bigquery job (how?).

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@tseaver tseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Oct 17, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

None are relevant to this PR, which is purely BigQuery.

@theacodes looks like Kokoro has gone from skipping everything (#6231) to running all tests regardless?

tseaver added 13 commits October 17, 2018 16:03
@tseaver
Add explicit test coverage for 'LoadJobConfig.allow_jagged_rows'.
ac176a8
@tseaver
Add explicit test coverage for 'LoadJobConfig.allow_quoted_newlines'.
7f050e9
@tseaver
Add explicit test coverage for 'LoadJobConfig.autodetect'.
5a0ab18
@tseaver
Add explicit test coverage for 'LoadJobConfig.create_disposition'.
b37caba
@tseaver
Add explicit test coverage for 'LoadJobConfig.encoding'.
29f4e6b
@tseaver
Add explicit test coverage for 'LoadJobConfig.field_delimiter'.
b6c37da
@tseaver
Add explicit test coverage for 'LoadJobConfig.ignore_unknown_values'.
5e8cae2
@tseaver
Add explicit test coverage for 'LoadJobConfig.max_bad_records'.
7a199fa
@tseaver
Add explicit test coverage for 'LoadJobConfig.null_marker'.
68fdf67
@tseaver
Add explicit test coverage for 'LoadJobConfig.quote_character'.
adf2710
@tseaver
Add explicit test coverage for 'LoadJobConfig.skip_leading_rows'.
51aade2 
Note question posted to issue #5093:  should 'max_bad_rows' and
'skip_leading_rows' match in how the mangle / parse the value in the
resource?  Docs say it is an integer.
@tseaver
Add explicit test coverage for 'LoadJobConfig.source_format'.
a345f58
@tseaver
Add explicit test coverage for 'LoadJobConfig.write_disposition'.
c739c10
tseaver added 13 commits October 17, 2018 16:03
@tseaver
Add/improve explicit test coverage for 'LoadJobConfig.schema'.
465aa61
@tseaver
Make EncryptionConfiguration instances comparable / hashable.
dbe59e7
@tseaver
Add/improve explicit test coverage for 'LoadJobConfig.destination_enc…
4d66817 
…ryption_configuration'.
@tseaver
Make 'TimePartitioning' comparable / hashable.
77e908d
@tseaver
Add/improve explicit test coverage for 'LoadJobConfig.time_partitioni…
a131731 
…ng'.
@tseaver
Fix 'LoadJobConfig.time_partitioning' setter w/ None.
b945c3c 
It should remove the 'timePartitioning' sub-key altogether.
@tseaver
Add/improve explicit test coverage for 'LoadJobConfig.clustering_fiel…
268e334 
…ds'.
@tseaver
Add explicit test coverage for 'LoadJobConfig.schema_update_options'.
c191f2f
@tseaver
Reorder 'LoadJobConfig' properties alphabetically.
3fafd08
@tseaver
Remove spurious test of superclass 'to_api_repr'/'from_api_repr' from…
7c76fe3 
… LJC tests.

Fix bug revealed thereby in 'LJC.destination_encryption_configuration' setter.
@tseaver
Add 'LoadTableConfig.destination_table_description' property.
8a1d4fa
@tseaver
Add 'LoadTableConfig.destination_table_friendly_name' property.
1240481 
Closes #5093.
@tseaver
Remove 'XXX' comments after resolving related question in review.
2a920d1
@tseaver tseaver force-pushed the 5093-bigquery-destination_table_props branch from 554b323 to 2a920d1 Compare October 17, 2018 20:03
@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

Rebased again to pick up api_core and pubsub testing changes from PRs #6242 and #6243.

@tseaver tseaver merged commit cf806f2 into master Oct 17, 2018
@tseaver tseaver deleted the 5093-bigquery-destination_table_props branch October 17, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @tswast @googlebot @kokoro-team