Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classmethod wrapping #5826

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Fix classmethod wrapping #5826

merged 2 commits into from
Aug 21, 2018

Conversation

theacodes
Copy link
Contributor

@theacodes theacodes commented Aug 21, 2018

Fixes #5789

@theacodes theacodes self-assigned this Aug 21, 2018
@theacodes theacodes requested a review from tseaver August 21, 2018 18:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 21, 2018
@theacodes theacodes merged commit b19fc95 into master Aug 21, 2018
@theacodes theacodes deleted the fix-wrapping branch August 21, 2018 19:25
@tseaver
Copy link
Contributor

tseaver commented Aug 21, 2018

@theacodes On second thought, don't we need a testcase which exercises the wrapping of a classmethod?

@theacodes
Copy link
Contributor Author

@tseaver we have one.

@tseaver
Copy link
Contributor

tseaver commented Aug 21, 2018

@theacodes Why wasn't it failing prior to this fix, then?

@theacodes
Copy link
Contributor Author

A wonderful question. This code is pretty wild to me.

So what was working before was this:

class_instance.class_method(...)

but what wasn't was:

Class.class_method(...)

which lead to #5789. We have a test for the former, but not the latter. I can add one if you want.

@tseaver
Copy link
Contributor

tseaver commented Aug 21, 2018

Seems like a test to catch future regressions is the Right Thing(TM).

@theacodes
Copy link
Contributor Author

#5828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants