Making Bucket.delete() work in face of eventual consistency. #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
changed the title
| max_results=self._MAX_OBJECTS_FOR_BUCKET_DELETE + 1)) | ||
| if len(blobs) > self._MAX_OBJECTS_FOR_BUCKET_DELETE: | ||
| raise ValueError('Refusing to delete bucket with more than ' | ||
| '256 objects. If you actually want to delete ' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Other than my quibble about the error message, LGTM. |
dhermes
force-pushed
the
storage-fix-564
branch
from
0543a2f to
85c64a3
Compare
dhermes
added a commit
that referenced
this pull request
Feb 3, 2015
Making Bucket.delete() work in face of eventual consistency.
|
@tseaver I folded your comment into the original commit during a rebase. Thanks. |
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…581) Source-Link: googleapis/synthtool@395d53a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564.