Make get_initial_request more resilient to race conditions. #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a rare case where the stream can be restarted while the streaming pull manager is shutting down. This causes get_initial_request to be called while the manager is in a bad state, which will trigger an AttributeError when attempting to read the list of outstanding Ack IDs from the leaser. Closes #5792
googlebot
added
the
cla: yes
crwilcox
approved these changes
Aug 14, 2018
AVaksman
pushed a commit
to AVaksman/google-cloud-python
that referenced
this pull request
Aug 16, 2018
…is#5803) There's a rare case where the stream can be restarted while the streaming pull manager is shutting down. This causes get_initial_request to be called while the manager is in a bad state, which will trigger an AttributeError when attempting to read the list of outstanding Ack IDs from the leaser. Closes googleapis#5792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a rare case where the stream can be restarted while the streaming pull
manager is shutting down. This causes get_initial_request to be called while
the manager is in a bad state, which will trigger an AttributeError when
attempting to read the list of outstanding Ack IDs from the leaser.
Closes #5792