Using httplib instead of httplib2 to get GCE metadata. #577
+75
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
I realized I need to use the |
Both - test_set_explicit_None_wo_env_var_set - test_no_env_var_set fall-through to the GCE check, but were actually making real HTTP calls before. This makes sure httplib is always stubbed out but also allows modification of that stub.
| connection.request('GET', uri_path, headers=headers) | ||
| response = connection.getresponse() | ||
| if response.status == 200: | ||
| content = response.read() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tseaver Any other comments before I push the |
|
Nope -- "merge when ready, Gridley!" |
dhermes
added a commit
that referenced
this pull request
Jan 29, 2015
Using httplib instead of httplib2 to get GCE metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575.
Feel free to run the bash script I included in the bug to torture test the fix.