PubSub: add geo-fencing support #5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egenerating v1 endpoint
googlebot
added
the
cla: yes
tseaver
changed the title
|
@crwilcox lint failures: nox > Running session lint
nox > /usr/local/bin/python3.6 -m virtualenv /var/code/gcp/.nox/lint -p python3.6
nox > chdir /var/code/gcp/pubsub
nox > pip install --upgrade flake8 ../api_core ../core
nox > pip install --upgrade .
nox > flake8 google tests
google/__init__.py:20:55: W292 no newline at end of file
google/cloud/__init__.py:20:55: W292 no newline at end of file
google/cloud/pubsub_v1/__init__.py:34:2: W292 no newline at end of file
nox > Command flake8 google tests failed with exit code 1
nox > Session lint failed. |
|
👋 Not sure why this is assigned to me :) |
|
@JustinBeckwith Heh, I don't even know what "assigned" means for a PR (vs. "review requested"). |
|
Looks like docs are not building. I will look at that and update this in a bit. |
theacodes
approved these changes
Aug 10, 2018
AVaksman
pushed a commit
to AVaksman/google-cloud-python
that referenced
this pull request
Aug 16, 2018
* Add support for storage location policy (geo-fencing) to Pub/Sub by regenerating v1 endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for storage location policy (geo-fencing) to Pub/Sub by regenerating v1 endpoint