Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add core dependency #3865

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Re-add core dependency #3865

merged 1 commit into from
Aug 24, 2017

Conversation

lukesneeringer
Copy link
Contributor

Re-adds the google-cloud-core dependency with the new version.
Fixes #3863.

@lukesneeringer lukesneeringer self-assigned this Aug 24, 2017
@lukesneeringer lukesneeringer requested a review from dhermes August 24, 2017 20:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2017
@dhermes
Copy link
Contributor

dhermes commented Aug 24, 2017

LGTM. Why was core removed to begin with?

@lukesneeringer
Copy link
Contributor Author

Because I had no dependencies on it. :-) I did not add google.api.core.Future until very late (yesterday), and did not catch it because tests were still installing it.

@lukesneeringer lukesneeringer merged commit 4c6801e into googleapis:master Aug 24, 2017
@lukesneeringer lukesneeringer deleted the pubsub-bump branch August 24, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes Awaiting requested review from dhermes

Assignees

@lukesneeringer lukesneeringer

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukesneeringer @dhermes @googlebot