Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bigquery system tests for query parameters with nested types #3180

Merged
merged 4 commits into from
Mar 22, 2017
Merged

Add bigquery system tests for query parameters with nested types #3180

merged 4 commits into from
Mar 22, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 21, 2017

Might be easier to review commit-by-commit.

Closes #2906, #3029.

tseaver added 4 commits March 21, 2017 15:42
@tseaver
Split out systests for query params from literal values.
0238887
@tseaver
Allow array query parameters w/ nested structs.
1dfffaf 
Add a system test to verify the feature.

Closes #2906.

Toward #3029.
@tseaver
Allow struct query parameters w/ nested structs.
7e6d4a1 
Add a system test to verify the feature.

Toward #3029.
@tseaver
Allow struct query parameters w/ nested arrays.
8b9dda2 
Add a system test to verify the feature.

Toward #3029.
@tseaver tseaver added api: bigquery Issues related to the BigQuery API. testing labels Mar 21, 2017
@tseaver tseaver requested review from daspecster and dhermes March 21, 2017 21:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2017
@tseaver tseaver mentioned this pull request Mar 21, 2017
Closed
@tseaver tseaver merged commit 1e83d92 into googleapis:master Mar 22, 2017
@tseaver tseaver deleted the 3029-bigquery-systest-query_params-nested branch March 22, 2017 17:47
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull request googleapis#3180 from tseaver/3029-bigquery-systest…
6b99c5c 
…-query_params-nested

Add bigquery system tests for query parameters with nested types
@tseaver tseaver mentioned this pull request May 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

@daspecster daspecster Awaiting requested review from daspecster

@dhermes dhermes Awaiting requested review from dhermes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @lukesneeringer @googlebot