Fix KeyError for unsupported annotation types. #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
commented
Jan 24, 2017
| @@ -87,6 +87,9 @@ def from_api_repr(cls, response): | |||
| :rtype: :class:`~google.cloud.vision.annotations.Annotations` | |||
| :returns: An instance of ``Annotations`` with detection types loaded. | |||
| """ | |||
| for feature_type in response.keys(): | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jonparrott @gguuss PTAL. (I can already image the bug reports: "where is my data") |
|
@dhermes the data isn't going to get loaded unless it's routed into the |
|
I am all kinds of nervous about just dropping extra fields, but it looks like #2930 has already covered this ground. So, okay. |
|
Bump! |
theacodes
approved these changes
Jan 30, 2017
|
This is fine with me. I believe this is what @gguuss had in mind - the data isn't there, but the library doesn't explode. |
|
Thanks @jonparrott! |
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
* Fix KeyError for unsupported annotation types.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Fix KeyError for unsupported annotation types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2930.