Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ImportError check in Speech client. #2665

Merged
merged 1 commit into from
Nov 2, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 2, 2016

I mentioned this in #2664 and this delivers on it.

We should also get rid of all the instances of this in other packages. LMK what you both think (and @jonparrott I'd be interested in what you think, i.e. importing grpc on GAE)

@dhermes dhermes added the api: speech Issues related to the Speech-to-Text API. label Nov 2, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2016
@theacodes
Copy link
Contributor

It's not ideal for GAE where the gRPC won't be available for some time, but we've already crossed that bridge it seems.

@dhermes
Copy link
Contributor Author

dhermes commented Nov 2, 2016

I'm going to leave this open before merging to let @tseaver weigh in.


we've already crossed that bridge it seems.

@jonparrott How do you mean?

@theacodes
Copy link
Contributor

we've already crossed that bridge it seems.

There are other locations where grpc is not import checked, right?

@dhermes
Copy link
Contributor Author

dhermes commented Nov 2, 2016

There are other locations where grpc is not import checked, right?

Not that I know of, except a change I made earlier today in speech. Unfortunately the PB definitions are bundled with grpc, so it's tough to parse the Any fields in the operations returned from the API (gRPC or JSON-over-HTTP) without importing the PB types.

@theacodes
Copy link
Contributor

@dhermes Gotcha. In that case I'm fine with this outside of datastore, logging, pubsub, storage, and logging.

@dhermes dhermes merged commit 40d545d into googleapis:master Nov 2, 2016
@dhermes dhermes deleted the speech-no-more-condl-import branch November 2, 2016 17:59
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
…import

Removing ImportError check in Speech client.
atulep pushed a commit that referenced this pull request Apr 3, 2023
Removing ImportError check in Speech client.
atulep pushed a commit that referenced this pull request Apr 18, 2023
Removing ImportError check in Speech client.
parthea pushed a commit that referenced this pull request Oct 22, 2023
Removing ImportError check in Speech client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants