Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing gcloud.credential.Credential class. #235

Merged
merged 2 commits into from
Oct 13, 2014

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 10, 2014

No instances of this class were ever created and it only had
one factory method, which is now a function. This class was
also misunderstood / misreferenced in the docstring mentions.


.. note::
You should not need to use this class directly.
You should not need to use this method directly.

This comment was marked as spam.

This comment was marked as spam.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling dfcc90b on dhermes:remove-credential-class into f44959a on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Oct 13, 2014

LGTM, aside from the 'method' -> 'function' change.

No instances of this class were ever created and it only had
one factory method, which is now a function. This class was
also misunderstood / misreferenced in the docstring mentions.
@dhermes dhermes force-pushed the remove-credential-class branch from a6ee6af to 698f3a2 Compare October 13, 2014 20:04
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 698f3a2 on dhermes:remove-credential-class into 398addf on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 698f3a2 on dhermes:remove-credential-class into 398addf on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Oct 13, 2014
Removing gcloud.credential.Credential class.
@tseaver tseaver merged commit a4dac56 into googleapis:master Oct 13, 2014
@dhermes dhermes added auth api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. labels Dec 31, 2015
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Enhanced Readme as suggested on googleapis#235
atulep pushed a commit that referenced this pull request Apr 3, 2023
- [ ] Regenerate this pull request now.

Committer: @jameszhao
PiperOrigin-RevId: 391603958

Source-Link: googleapis/googleapis@76bed90

Source-Link: googleapis/googleapis-gen@c7aaaa7
atulep pushed a commit that referenced this pull request Apr 6, 2023
- [ ] Regenerate this pull request now.

Committer: @jameszhao
PiperOrigin-RevId: 391603958

Source-Link: googleapis/googleapis@76bed90

Source-Link: googleapis/googleapis-gen@c7aaaa7
atulep pushed a commit that referenced this pull request Apr 6, 2023
- [ ] Regenerate this pull request now.

Committer: @jameszhao
PiperOrigin-RevId: 391603958

Source-Link: googleapis/googleapis@76bed90

Source-Link: googleapis/googleapis-gen@c7aaaa7
atulep pushed a commit that referenced this pull request Apr 18, 2023
- [ ] Regenerate this pull request now.

Committer: @jameszhao
PiperOrigin-RevId: 391603958

Source-Link: googleapis/googleapis@76bed90

Source-Link: googleapis/googleapis-gen@c7aaaa7
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320
parthea pushed a commit that referenced this pull request Aug 15, 2023
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea pushed a commit that referenced this pull request Sep 20, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 473833416

Source-Link: googleapis/googleapis@565a550

Source-Link: googleapis/googleapis-gen@1ee1a06
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@38e11ad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
parthea added a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Sep 22, 2023
…235)

Source-Link: googleapis/synthtool@6b4d5a6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f792ee1320e03eda2d13a5281a2989f7ed8a9e50b73ef6da97fac7e1e850b149

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@38e11ad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@f8077d2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:dfa9b663b32de8b5b327e32c1da665a80de48876558dd58091d8160c60ad7355

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@52e4e46
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605
parthea pushed a commit that referenced this pull request Oct 21, 2023
🤖 I have created a release \*beep\* \*boop\*
---
## [3.3.0](https://www.github.com/googleapis/python-asset/compare/v3.2.1...v3.3.0) (2021-07-28)


### Features

* Add AnalyzeMove API ([a242adc](https://www.github.com/googleapis/python-asset/commit/a242adc8864724acb2d12136bb09d68cb7fc729c))
* Add AttachedResource field for ResourceSearchResult ([a242adc](https://www.github.com/googleapis/python-asset/commit/a242adc8864724acb2d12136bb09d68cb7fc729c))
* Add read_mask field for SearchAllResourcesRequest ([a242adc](https://www.github.com/googleapis/python-asset/commit/a242adc8864724acb2d12136bb09d68cb7fc729c))
* Add VersionedResource field for ResourceSearchResult ([a242adc](https://www.github.com/googleapis/python-asset/commit/a242adc8864724acb2d12136bb09d68cb7fc729c))
* Change metadata field for the AnalyzeIamPolicyLongrunning ([#245](https://www.github.com/googleapis/python-asset/issues/245)) ([a242adc](https://www.github.com/googleapis/python-asset/commit/a242adc8864724acb2d12136bb09d68cb7fc729c))


### Bug Fixes

* enable self signed jwt for grpc ([#244](https://www.github.com/googleapis/python-asset/issues/244)) ([a15e185](https://www.github.com/googleapis/python-asset/commit/a15e18574ce4d58a22955284ebfe444c152b30c7))


### Documentation

* add Samples section to CONTRIBUTING.rst ([#235](https://www.github.com/googleapis/python-asset/issues/235)) ([0d00e75](https://www.github.com/googleapis/python-asset/commit/0d00e75bf46d52beea0829b83a2df580a37491ca))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@82f5cb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Maciej Strzelczyk <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 401594069

Source-Link: googleapis/googleapis@3b9c98e

Source-Link: googleapis/googleapis-gen@b892911
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjg5MjkxMWNmOWY3MWQ3YmQxNTRhY2Q5MjhkOGE1ODBkZDUxOWY3MSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/python-monitoring/compare/v2.5.2...v2.6.0) (2021-11-01)


### Features

* add context manager support in client ([#230](https://www.github.com/googleapis/python-monitoring/issues/230)) ([954dd18](https://www.github.com/googleapis/python-monitoring/commit/954dd18966520dbc623470ef528166d83d3e19ba))
* add CreateServiceTimeSeries RPC ([#235](https://www.github.com/googleapis/python-monitoring/issues/235)) ([2970b22](https://www.github.com/googleapis/python-monitoring/commit/2970b22ca5b4959ee1d3e1e883cdb00951e3917f))


### Bug Fixes

* **deps:** drop packaging dependency ([22d4eab](https://www.github.com/googleapis/python-monitoring/commit/22d4eabbafbdc16b0f4faf66f966442691de7666))
* **deps:** require google-api-core >= 1.28.0 ([22d4eab](https://www.github.com/googleapis/python-monitoring/commit/22d4eabbafbdc16b0f4faf66f966442691de7666))
* Reintroduce deprecated field/enum `ServiceTier` for backward compatibility ([#240](https://www.github.com/googleapis/python-monitoring/issues/240)) ([eeb0534](https://www.github.com/googleapis/python-monitoring/commit/eeb05347eaf6e7a0794e679d83fe70a0db6a02a3))


### Documentation

* list oneofs in docstring ([22d4eab](https://www.github.com/googleapis/python-monitoring/commit/22d4eabbafbdc16b0f4faf66f966442691de7666))
* Use absolute link targets in comments ([eeb0534](https://www.github.com/googleapis/python-monitoring/commit/eeb05347eaf6e7a0794e679d83fe70a0db6a02a3))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@d2871d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
* Synchronize new proto/yaml changes.

PiperOrigin-RevId: 446264416

Source-Link: googleapis/googleapis@3a976a3

Source-Link: googleapis/googleapis-gen@0548a71
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDU0OGE3MTZhMDEzODMzODIzNDQ5NThhYjIwYmI0ZDUyMjM4ODE1NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 22, 2023
* feat: enable "rest" transport in Python for services supporting numeric enums

PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: googleapis/googleapis-gen@6ad1279
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.8.5

PiperOrigin-RevId: 511892190

Source-Link: googleapis/googleapis@a45d9c0

Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix build

* feat: Import of Grafeas from Github

PiperOrigin-RevId: 513603965

Source-Link: googleapis/googleapis@7044962

Source-Link: googleapis/googleapis-gen@0ca25aa
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGNhMjVhYTEyNDVjZTQwNTdmM2ZiZDg4NjUzZTU4OTcwNzMxZjU3MSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* restore credentials

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Victor Chudnovsky <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this pull request Oct 22, 2023
* fix(deps): allow protobuf 3.19.5

* explicitly exclude protobuf 4.21.0
parthea pushed a commit that referenced this pull request Oct 22, 2023
- [ ] Regenerate this pull request now.

Committer: @jameszhao
PiperOrigin-RevId: 391603958

Source-Link: googleapis/googleapis@76bed90

Source-Link: googleapis/googleapis-gen@c7aaaa7
parthea pushed a commit that referenced this pull request Oct 31, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants