Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PEP8 only lint rule to tox and Travis. #217

Merged
merged 3 commits into from
Oct 7, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ script:
- tox -e py27
after_success:
- tox -e cover
- tox -e lint
- coveralls
5 changes: 3 additions & 2 deletions gcloud/test_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def authorize(self, http):

def test_user_agent_format(self):
from pkg_resources import get_distribution
expected_ua = 'gcloud-python/{0}'.format(get_distribution('gcloud').version)
conn = self._makeOne()
expected_ua = 'gcloud-python/{0}'.format(
get_distribution('gcloud').version)
conn = self._makeOne()
self.assertEqual(conn.USER_AGENT, expected_ua)
14 changes: 13 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist =
py26,py27,cover,docs
py26,py27,cover,docs,lint

[testenv]
commands =
Expand Down Expand Up @@ -28,3 +28,15 @@ commands =
sphinx-build -b html -d docs/_build/doctrees docs docs/_build/html
deps =
Sphinx

[pep8]
exclude = gcloud/datastore/datastore_v1_pb2.py,docs/conf.py,*.egg/,.*/
verbose = 1

[testenv:lint]
basepython =
python2.7
commands =
pep8

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

deps =
pep8