-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing usage of the gRPC beta subpackage. #2149
Conversation
We'll also now need to update https://github.com/GoogleCloudPlatform/google-cloud-python-happybase |
e6d01d8
to
901a267
Compare
901a267
to
49af4df
Compare
@nathanielmanistaatgoogle It's also worth noting that GAX is still using the beta API /cc @bjwatson I realized that and had to modify |
I created googleapis/gax-python#126 to track this. |
from grpc.beta import implementations | ||
from google.gax.grpc import exc_to_code as beta_exc_to_code | ||
import grpc | ||
from grpc._channel import _Rendezvous |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also fixing a test mock failure for gcloud._helpers.
def __exit__(self, exc_type, exc_val, exc_t): | ||
"""Stops the client as a context manager.""" | ||
self.stop() | ||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Did we ditch the timeouts because the GA API no longer supports them? I like the simplicity on our side, but worry that users might still need them. |
LGTM |
@nathanielmanistaatgoogle Filed #2156 to discuss our current disagreement on interface. @tseaver needs this PR for some upstream so "let's don't" block him and we can hopefully get more changes in as a resolution of #2156. |
Fixes #2130.
Most noteworthy is that the "stable" gRPC doesn't have
__exit__
and__enter__
and that the stubs are actual classes (instead of some instance of a private and esoteric class).When scanning for the case-insenstive string grpc I also found some things to change in other parts of the codebase I came across (e.g. a virtualenv root path falling back to
protoc
)@nathanielmanistaatgoogle PTAL
In particular we went from the public exception type
grpc.framework.interfaces.face.face.AbortionError
to the privategrpc._channel._Rendezvous
.How are we or users supposed to build in error handling? Should we catch
grpc.Error
(which_Rendezvous
inherits from)?BIG WORRY: Every system tests finishes with