-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LICENSE headers to gcloud.streaming. #2004
Conversation
@tseaver The failure is lint:
I can temporarily disable for the file or temporarily raise the limit and deal with after this PR? I'm expecting to lean out this code a bit as I pass through to factor out |
I think that's fine. It's barely 1% over. |
@daspecster I was asking @tseaver because he dislikes the churn (as do I) in the settings |
Gotcha, |
Yup that was
but I wouldn't use the obfuscated |
@tseaver PTAL |
Grrr, arbirtray limits bite us again. Go ahead with a per-file override, I think. |
LGTM once pylint is appeased. |
7b10f5c
to
2513386
Compare
No description provided.