Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable broken wheel building #1938

Merged
merged 2 commits into from
Jun 29, 2016
Merged

Disable broken wheel building #1938

merged 2 commits into from
Jun 29, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 29, 2016

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2016
@tseaver tseaver changed the title 1879 disable broken wheel building Disable broken wheel building Jun 29, 2016
@dhermes
Copy link
Contributor

dhermes commented Jun 29, 2016

LGTM (didn't this already get merged?)

@tseaver
Copy link
Contributor Author

tseaver commented Jun 29, 2016

@dhermes I merged it to the release-0.16.1 branch: this PR is for master.

@tseaver tseaver merged commit 4dc58fc into googleapis:master Jun 29, 2016
@tseaver tseaver deleted the 1879-disable-broken-wheel-building branch June 29, 2016 18:49
@dhermes
Copy link
Contributor

dhermes commented Jun 29, 2016

@tseaver We want this back ASAP (once the if statement is out of setup.py, le sigh). What will force our hand to revert this PR?

@daspecster
Copy link
Contributor

We could make an issue/reminder kind of like @tseaver did for #1873.

@tseaver tseaver mentioned this pull request Jun 29, 2016
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Jun 29, 2016

@daspecster done: #1939.

@tseaver tseaver mentioned this pull request Jun 29, 2016
Merged
@thisbejim thisbejim mentioned this pull request Jun 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @daspecster @googlebot