Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging to README.md. #1901

Merged
merged 2 commits into from
Jun 27, 2016

Conversation

daspecster
Copy link
Contributor

@tseaver LMKWYT and if there's anything I should add.
/cc @dhermes

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2016
@daspecster daspecster changed the title Add Logging to README.md. closes #1898. Add Logging to README.md. Jun 24, 2016
logger = client.logger('log_name')
logger.log_text("A simple entry") # API call


This comment was marked as spam.

@tseaver
Copy link
Contributor

tseaver commented Jun 26, 2016

LGTM, even if you decide to ignore my nitpick.

@tseaver
Copy link
Contributor

tseaver commented Jun 26, 2016

Hmm, maybe flesh the example out to show fetching entries? E.g.:

>>> entries, token = logger.list_entries()
>>> for entry in entries:
...   print entry.payload
A simple entry

@tseaver
Copy link
Contributor

tseaver commented Jun 26, 2016

@daspecster reminder to close #1898 after merge (I think having closes #1898 at the end of the first line of the commit message hides it from Github).

@tseaver
Copy link
Contributor

tseaver commented Jun 27, 2016

LGTM.

@daspecster daspecster merged commit 5c4db0d into googleapis:master Jun 27, 2016
@daspecster daspecster deleted the add-logging-to-readme branch June 27, 2016 16:18
@daspecster
Copy link
Contributor Author

@tseaver looks like the closes #1898 in the commit message worked!

@tseaver tseaver mentioned this pull request Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants