Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs side-nav background. #1733

Merged

Conversation

daspecster
Copy link
Contributor

@daspecster daspecster commented Apr 22, 2016

This allows the side-nav background color to extend
to the bottom of the screen.

Before:
side-nav-before

After:
side-nav-after

This allows the side-nav background color to extend
to the bottom of the screen.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2016
@daspecster daspecster changed the title Remove background: none; Fix side-nav background. Apr 22, 2016
@daspecster daspecster changed the title Fix side-nav background. Fix docs side-nav background. Apr 22, 2016
@dhermes
Copy link
Contributor

dhermes commented Apr 22, 2016

LGTM. FWIW we've had #1704 and #1028 for this but both were closed since we will be ditching this template once the generic gcloud-common template is in use.

@daspecster
Copy link
Contributor Author

Ah, I should have searched. Thanks @dhermes!

Should I merge or you? I'm in practice of not merging my own code for peer reviewing.

@dhermes
Copy link
Contributor

dhermes commented Apr 22, 2016

When it is amongst @tseaver and myself, the author does the merge. (In causes where a contributor can't merge, then the reviewer does.)

@daspecster daspecster merged commit 69f481b into googleapis:master Apr 22, 2016
@daspecster daspecster deleted the fix-docs-left-nav-background branch April 22, 2016 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants