Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Topic.get_iam_policy' API wrapper. #1640

Merged
merged 6 commits into from
Mar 22, 2016
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/index.rst
Original file line number Diff line number Diff line change
@@ -40,6 +40,7 @@
pubsub-topic
pubsub-subscription
pubsub-message
pubsub-iam

.. toctree::
:maxdepth: 0
8 changes: 8 additions & 0 deletions docs/pubsub-iam.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
IAM Policy
~~~~~~~~~~

.. automodule:: gcloud.pubsub.iam
:members:
:undoc-members:
:show-inheritance:

17 changes: 17 additions & 0 deletions docs/pubsub-usage.rst
Original file line number Diff line number Diff line change
@@ -66,6 +66,23 @@ Delete a topic:
>>> topic = client.topic('topic_name')
>>> topic.delete() # API request

Fetch the IAM policy for a topic:

This comment was marked as spam.

This comment was marked as spam.


.. doctest::

>>> from gcloud import pubsub
>>> client = pubsub.Client()
>>> topic = client.topic('topic_name')
>>> policy = topic.get_iam_policy() # API request
>>> policy.etag
'DEADBEEF'
>>> policy.owners
['user:[email protected]']
>>> policy.writers
['systemAccount':[email protected]']

This comment was marked as spam.

This comment was marked as spam.

>>> policy.readers
['doman':example.com']


Publish messages to a topic
---------------------------
160 changes: 160 additions & 0 deletions gcloud/pubsub/iam.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
# Copyright 2016 Google Inc. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""PubSub API IAM policy definitions"""


class Policy(object):
"""Combined IAM Policy / Bindings.

See:
https://cloud.google.com/pubsub/reference/rest/Shared.Types/Policy
https://cloud.google.com/pubsub/reference/rest/Shared.Types/Binding

:type etag: string
:param etag: ETag used to identify a unique of the policy

:type version: int
:param version: unique version of the policy
"""
def __init__(self, etag=None, version=None):
self.etag = etag
self.version = version
self.owners = set()
self.writers = set()
self.readers = set()

@staticmethod
def user(email):
"""Factory method for a user member.

:type email: string
:param email: E-mail for this particular user.

:rtype: string
:returns: A member string corresponding to the given user.
"""
return 'user:%s' % (email,)

@staticmethod
def service_account(email):
"""Factory method for a user member.

This comment was marked as spam.

This comment was marked as spam.


:type email: string
:param email: E-mail for this particular user.

:rtype: string
:returns: A member string corresponding to the given service account.
"""
return 'serviceAccount:%s' % (email,)

@staticmethod
def group(email):
"""Factory method for a group member.

:type email: string
:param email: An id or e-mail for this particular group.

:rtype: string
:returns: A member string corresponding to the given group.
"""
return 'group:%s' % (email,)

@staticmethod
def domain(domain):
"""Factory method for a domain member.

:type domain: string
:param domain: The domain for this member.

:rtype: string
:returns: A member string corresponding to the given domain.
"""
return 'domain:%s' % (domain,)

@staticmethod
def all_users():
"""Factory method for an member representing all users.

This comment was marked as spam.

This comment was marked as spam.


:rtype: string
:returns: A member string representing all users.
"""
return 'allUsers'

@staticmethod
def authenticated_users():
"""Factory method for an member representing all authenticated users.

This comment was marked as spam.

This comment was marked as spam.


:rtype: string
:returns: A member string representing all authenticated users.
"""
return 'allAuthenticatedUsers'

@classmethod
def from_api_repr(cls, resource):
"""Create a policy from the resource returned from the API.

:type resource: dict
:param resource: resource returned from the ``getIamPolicy`` API.

:rtype: :class:`Policy`
:returns: the parsed policy
"""
version = resource.get('version')
etag = resource.get('etag')
policy = cls(etag, version)
for binding in resource.get('bindings', ()):
role = binding['role']
members = set(binding['members'])
if role == 'roles/owner':
policy.owners = members
elif role == 'roles/writer':
policy.writers = members
elif role == 'roles/reader':
policy.readers = members
else:
raise ValueError('Unknown role: %s' % (role,))

This comment was marked as spam.

return policy

def to_api_repr(self):
"""Construct a Policy resource.

:rtype: dict
:returns: a resource to be passed to the ``setIamPolicy`` API.
"""
resource = {}

if self.etag is not None:
resource['etag'] = self.etag

if self.version is not None:
resource['version'] = self.version

bindings = []

if self.owners:
bindings.append(
{'role': 'roles/owner', 'members': sorted(self.owners)})

This comment was marked as spam.

This comment was marked as spam.


if self.writers:
bindings.append(
{'role': 'roles/writer', 'members': sorted(self.writers)})

if self.readers:
bindings.append(
{'role': 'roles/reader', 'members': sorted(self.readers)})

if bindings:
resource['bindings'] = bindings

return resource
158 changes: 158 additions & 0 deletions gcloud/pubsub/test_iam.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,158 @@
# Copyright 2016 Google Inc. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import unittest2


class TestPolicy(unittest2.TestCase):

def _getTargetClass(self):
from gcloud.pubsub.iam import Policy
return Policy

def _makeOne(self, *args, **kw):
return self._getTargetClass()(*args, **kw)

def test_ctor_defaults(self):
policy = self._makeOne()
self.assertEqual(policy.etag, None)
self.assertEqual(policy.version, None)
self.assertEqual(list(policy.owners), [])
self.assertEqual(list(policy.writers), [])
self.assertEqual(list(policy.readers), [])

def test_ctor_explicit(self):
VERSION = 17
ETAG = 'ETAG'
policy = self._makeOne(ETAG, VERSION)
self.assertEqual(policy.etag, ETAG)
self.assertEqual(policy.version, VERSION)
self.assertEqual(list(policy.owners), [])
self.assertEqual(list(policy.writers), [])
self.assertEqual(list(policy.readers), [])

def test_user(self):
EMAIL = '[email protected]'
MEMBER = 'user:%s' % (EMAIL,)
policy = self._makeOne()
self.assertEqual(policy.user(EMAIL), MEMBER)

def test_service_account(self):
EMAIL = '[email protected]'
MEMBER = 'serviceAccount:%s' % (EMAIL,)
policy = self._makeOne()
self.assertEqual(policy.service_account(EMAIL), MEMBER)

def test_group(self):
EMAIL = '[email protected]'
MEMBER = 'group:%s' % (EMAIL,)
policy = self._makeOne()
self.assertEqual(policy.group(EMAIL), MEMBER)

def test_domain(self):
DOMAIN = 'example.com'
MEMBER = 'domain:%s' % (DOMAIN,)
policy = self._makeOne()
self.assertEqual(policy.domain(DOMAIN), MEMBER)

def test_all_users(self):
policy = self._makeOne()
self.assertEqual(policy.all_users(), 'allUsers')

def test_authenticated_users(self):
policy = self._makeOne()
self.assertEqual(policy.authenticated_users(), 'allAuthenticatedUsers')

def test_from_api_repr_only_etag(self):
RESOURCE = {
'etag': 'ACAB',
}
klass = self._getTargetClass()
policy = klass.from_api_repr(RESOURCE)
self.assertEqual(policy.etag, 'ACAB')
self.assertEqual(policy.version, None)
self.assertEqual(list(policy.owners), [])
self.assertEqual(list(policy.writers), [])
self.assertEqual(list(policy.readers), [])

def test_from_api_repr_complete(self):
OWNER1 = 'user:[email protected]'
OWNER2 = 'group:[email protected]'
WRITER1 = 'domain:google.com'
WRITER2 = 'user:[email protected]'
READER1 = 'serviceAccount:[email protected]'
READER2 = 'user:[email protected]'
RESOURCE = {
'etag': 'DEADBEEF',
'version': 17,
'bindings': [
{'role': 'roles/owner', 'members': [OWNER1, OWNER2]},
{'role': 'roles/writer', 'members': [WRITER1, WRITER2]},
{'role': 'roles/reader', 'members': [READER1, READER2]},
],
}
klass = self._getTargetClass()
policy = klass.from_api_repr(RESOURCE)
self.assertEqual(policy.etag, 'DEADBEEF')
self.assertEqual(policy.version, 17)
self.assertEqual(sorted(policy.owners), [OWNER2, OWNER1])
self.assertEqual(sorted(policy.writers), [WRITER1, WRITER2])
self.assertEqual(sorted(policy.readers), [READER1, READER2])

def test_from_api_repr_bad_role(self):
BOGUS1 = 'user:[email protected]'
BOGUS2 = 'group:[email protected]'
RESOURCE = {
'etag': 'DEADBEEF',
'version': 17,
'bindings': [
{'role': 'nonesuch', 'members': [BOGUS1, BOGUS2]},
],
}
klass = self._getTargetClass()
with self.assertRaises(ValueError):
klass.from_api_repr(RESOURCE)

def test_to_api_repr_defaults(self):
policy = self._makeOne()
self.assertEqual(policy.to_api_repr(), {})

def test_to_api_repr_only_etag(self):
policy = self._makeOne('DEADBEEF')
self.assertEqual(policy.to_api_repr(), {'etag': 'DEADBEEF'})

def test_to_api_repr_full(self):
OWNER1 = 'group:[email protected]'
OWNER2 = 'user:[email protected]'
WRITER1 = 'domain:google.com'
WRITER2 = 'user:[email protected]'
READER1 = 'serviceAccount:[email protected]'
READER2 = 'user:[email protected]'
EXPECTED = {
'etag': 'DEADBEEF',
'version': 17,
'bindings': [
{'role': 'roles/owner', 'members': [OWNER1, OWNER2]},
{'role': 'roles/writer', 'members': [WRITER1, WRITER2]},
{'role': 'roles/reader', 'members': [READER1, READER2]},
],
}
policy = self._makeOne('DEADBEEF', 17)
policy.owners.add(OWNER1)
policy.owners.add(OWNER2)
policy.writers.add(WRITER1)
policy.writers.add(WRITER2)
policy.readers.add(READER1)
policy.readers.add(READER2)
self.assertEqual(policy.to_api_repr(), EXPECTED)
67 changes: 67 additions & 0 deletions gcloud/pubsub/test_topic.py
Original file line number Diff line number Diff line change
@@ -452,6 +452,73 @@ def test_list_subscriptions_missing_key(self):
% (PROJECT, TOPIC_NAME))
self.assertEqual(req['query_params'], {})

def test_get_iam_policy_w_bound_client(self):
OWNER1 = 'user:phred@example.com'
OWNER2 = 'group:cloud-logs@google.com'
WRITER1 = 'domain:google.com'
WRITER2 = 'user:phred@example.com'
READER1 = 'serviceAccount:1234-abcdef@service.example.com'
READER2 = 'user:phred@example.com'
POLICY = {
'etag': 'DEADBEEF',
'version': 17,
'bindings': [
{'role': 'roles/owner', 'members': [OWNER1, OWNER2]},
{'role': 'roles/writer', 'members': [WRITER1, WRITER2]},
{'role': 'roles/reader', 'members': [READER1, READER2]},
],
}
TOPIC_NAME = 'topic_name'
PROJECT = 'PROJECT'
TOPIC_NAME = 'topic_name'
PATH = 'projects/%s/topics/%s:getIamPolicy' % (PROJECT, TOPIC_NAME)

conn = _Connection(POLICY)
CLIENT = _Client(project=PROJECT, connection=conn)
topic = self._makeOne(TOPIC_NAME, client=CLIENT)

policy = topic.get_iam_policy()

self.assertEqual(policy.etag, 'DEADBEEF')
self.assertEqual(policy.version, 17)
self.assertEqual(sorted(policy.owners), [OWNER2, OWNER1])
self.assertEqual(sorted(policy.writers), [WRITER1, WRITER2])
self.assertEqual(sorted(policy.readers), [READER1, READER2])

self.assertEqual(len(conn._requested), 1)
req = conn._requested[0]
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['path'], '/%s' % PATH)

def test_get_iam_policy_w_alternate_client(self):
POLICY = {
'etag': 'ACAB',
}
TOPIC_NAME = 'topic_name'
PROJECT = 'PROJECT'
TOPIC_NAME = 'topic_name'
PATH = 'projects/%s/topics/%s:getIamPolicy' % (PROJECT, TOPIC_NAME)

conn1 = _Connection()
conn2 = _Connection(POLICY)
CLIENT1 = _Client(project=PROJECT, connection=conn1)
CLIENT2 = _Client(project=PROJECT, connection=conn2)
topic = self._makeOne(TOPIC_NAME, client=CLIENT1)

policy = topic.get_iam_policy(client=CLIENT2)

self.assertEqual(policy.etag, 'ACAB')
self.assertEqual(policy.version, None)
self.assertEqual(sorted(policy.owners), [])
self.assertEqual(sorted(policy.writers), [])
self.assertEqual(sorted(policy.readers), [])

self.assertEqual(len(conn1._requested), 0)
self.assertEqual(len(conn2._requested), 1)
req = conn2._requested[0]
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['path'], '/%s' % PATH)


class TestBatch(unittest2.TestCase):

20 changes: 20 additions & 0 deletions gcloud/pubsub/topic.py
Original file line number Diff line number Diff line change
@@ -21,6 +21,7 @@
from gcloud.exceptions import NotFound
from gcloud.pubsub._helpers import subscription_name_from_path
from gcloud.pubsub._helpers import topic_name_from_path
from gcloud.pubsub.iam import Policy
from gcloud.pubsub.subscription import Subscription


@@ -258,6 +259,25 @@ def list_subscriptions(self, page_size=None, page_token=None, client=None):
subscriptions.append(Subscription(sub_name, self))
return subscriptions, resp.get('nextPageToken')

def get_iam_policy(self, client=None):
"""Fetch the IAM policy for the topic.
See:
https://cloud.google.com/pubsub/reference/rest/v1/projects.topics/getIamPolicy
:type client: :class:`gcloud.pubsub.client.Client` or ``NoneType``
:param client: the client to use. If not passed, falls back to the
``client`` stored on the current batch.
:rtype: :class:`gcloud.pubsub.iam.Policy`
:returns: policy created from the resource returned by the
``getIamPolicy`` API request.
"""
client = self._require_client(client)
path = '%s:getIamPolicy' % (self.path,)
resp = client.connection.api_request(method='GET', path=path)
return Policy.from_api_repr(resp)


class Batch(object):
"""Context manager: collect messages to publish via a single API call.