#798: Add support for auto-acknowledging pulled messages. #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
do not merge
googlebot
added
the
cla: yes
| @@ -272,3 +272,30 @@ Fetch messages for a pull subscription without blocking (none pending): | |||
| >>> messages = [recv[1] for recv in received] | |||
| >>> [message.message_id for message in messages] | |||
| [] | |||
|
|
|||
| Fetch pending messages, acknowledging those whose processing doesn't raise an | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| ... batch.publish('this is the second message_payload', | ||
| ... attr1='value1', attr2='value2') | ||
| >>> from gcloud.pubsub.subscription import AutoAck | ||
| >>> with AutoAck(subscription, max_messages=10) as ack: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
removed
the
do not merge
|
LGTM, I don't really have the whole story for this though. |
Follows @tmatsuo's suggested implementation in: #798 (comment) Closes #798.
Addresses (on the other PR): #1637 (comment)
|
Rebased to pick up pylint fixes on |
This was referenced Aug 3, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows @tmatsuo's suggested implementation.
Closes #798.
Hold off merging until comparing with the alternate implementation suggested by @jgeewax. (#1637)