Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden pubsub client against keys omitted in back-end responses #1440

Merged
merged 3 commits into from
Feb 15, 2016
Merged

Harden pubsub client against keys omitted in back-end responses #1440

merged 3 commits into from
Feb 15, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 2, 2016

See #1439.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Feb 2, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2016
@dhermes
Copy link
Contributor

dhermes commented Feb 2, 2016

LGTM.

Worth adding to system tests?

@tseaver
Copy link
Contributor Author

tseaver commented Feb 3, 2016

Worth adding to system tests?

I'm not sure how to provoke it, given that an account might have an existing topic / subscription.

@dhermes
Copy link
Contributor

dhermes commented Feb 3, 2016

Well we could do this for checking subscriptions on the topics we create, right?

@tseaver tseaver mentioned this pull request Feb 15, 2016
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Feb 15, 2016

@dhermes PTAL at e6616ca.

@dhermes
Copy link
Contributor

dhermes commented Feb 15, 2016

LGTM (feel free to merge before AppVeyor finishes)

tseaver added a commit that referenced this pull request Feb 15, 2016
@tseaver
Merge pull request #1440 from tseaver/1439-pubsub-harden_against_miss…
4d94911 
…ing_keys

Harden pubsub client against keys omitted in back-end responses
@tseaver tseaver merged commit 4d94911 into googleapis:master Feb 15, 2016
@tseaver tseaver deleted the 1439-pubsub-harden_against_missing_keys branch February 15, 2016 19:35
@dhermes dhermes mentioned this pull request Feb 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot