Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing use of isolation level in datastore. #1407

Merged
merged 1 commit into from
Jan 29, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 21, 2016

In v1beta3 all transactions are serializable.

In `v1beta3` all transactions are serializable.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Jan 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Jan 21, 2016

Was #1343

@dhermes dhermes mentioned this pull request Jan 21, 2016
49 tasks
@dhermes
Copy link
Contributor Author

dhermes commented Jan 28, 2016

@tseaver PTAL

@tseaver
Copy link
Contributor

tseaver commented Jan 29, 2016

LGTM

dhermes added a commit that referenced this pull request Jan 29, 2016
Removing use of isolation level in datastore.
@dhermes dhermes merged commit cf06ef8 into googleapis:datastore-v1beta3 Jan 29, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Jan 29, 2016

@tseaver Any ideas for a good way to manage the datastore-v1beta3 branch / keep it up to date with master? Should I send PRs for the rebases?

@tseaver
Copy link
Contributor

tseaver commented Jan 29, 2016

I'd say we could just merge master to it before merging it back: since it is a long-lived integration branch, the extra merge(s) (might be more than one) actually document keeping it up to date.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 29, 2016

OK.

@dhermes dhermes deleted the ditch-iso-level branch January 29, 2016 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants