Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix docs build #12881

Merged
merged 3 commits into from
Jul 8, 2024
Merged

build: fix docs build #12881

merged 3 commits into from
Jul 8, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 8, 2024

In PR #12634, .kokoro/docker/docs/Dockerfile was updated to use ubuntu:24.04. The previous version ubuntu:22.04 had Python 3.10 installed by default. In ubuntu:24.04, Python 3.12 is the default version. We need to restore Python 3.10 which is used in both the docs and docfx nox sessions.

@nox.session(python=DEFAULT_PYTHON_VERSION)
def docs(session):

@nox.session(python=DEFAULT_PYTHON_VERSION)
def docfx(session):

I tested that this builds successfully by running docker build -t test_docs_mono_repo . in the directory kokoro/docker/docs

I then ran the nox sessions docs and docfx.

Use this command to run the docker container and enter into bash

docker run --rm -it --entrypoint /bin/bash test_docs_mono_repo

Then in the docker container, run the following commands

git clone https://github.com/googleapis/google-cloud-python.git
cd google-cloud-python/packages/google-cloud-access-approval
nox -s docs
nox -s docfx

@parthea parthea requested a review from a team as a code owner July 8, 2024 19:17
@parthea parthea merged commit 5834030 into main Jul 8, 2024
19 checks passed
@parthea parthea deleted the fix-docs-build-dockerfile branch July 8, 2024 19:25
@parthea parthea mentioned this pull request Jul 31, 2024
parthea added a commit that referenced this pull request Jul 31, 2024
This PR fixes the docs build which started failing as of
#12634 and
#12881.

I tested these changes by re-triggering a docs build which previously
failed, with the changes from this PR.

See related PR googleapis/synthtool#1996 and
related issue b/356444150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants