Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Bigtable Table.rename(). #1283

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Implementing Bigtable Table.rename(). #1283

merged 1 commit into from
Dec 16, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 11, 2015

No description provided.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Dec 11, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2015
tseaver
tseaver reviewed Dec 11, 2015
View reviewed changes
gcloud/bigtable/table.py
``BigtableTableService.RenameTable is not yet implemented``

when this method is used. It's unclear when this method will
actually be supported by the API.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Dec 11, 2015

Implementation LGTM, given that we want to add the rename method at all.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 15, 2015

@tseaver How to proceed?

@tseaver
Copy link
Contributor

tseaver commented Dec 15, 2015

@dhermes Let's add a .. note: in the docstring that as of whichever API version we are supporting, the method is not implemented on the backend, and add an issue to review when we move to a new version.

@dhermes dhermes mentioned this pull request Dec 16, 2015
Closed
@dhermes dhermes force-pushed the bigtable-table-rename branch from f313ca9 to 9bbbeb3 Compare December 16, 2015 05:12
@dhermes
Copy link
Contributor Author

dhermes commented Dec 16, 2015

@tseaver Filed #1289 for followup. I added v1 to the note about

BigtableTableService.RenameTable is not yet implemented

LMK if we are a go to merge.

@tseaver
Copy link
Contributor

tseaver commented Dec 16, 2015

LGTM

dhermes added a commit that referenced this pull request Dec 16, 2015
@dhermes
Merge pull request #1283 from dhermes/bigtable-table-rename
94c007d 
Implementing Bigtable Table.rename().
@dhermes dhermes merged commit 94c007d into googleapis:master Dec 16, 2015
@dhermes dhermes deleted the bigtable-table-rename branch December 16, 2015 06:02
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @nathanielmanistaatgoogle @googlebot