Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v1beta1): Allow users to explicitly configure universe domain #12324

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 16, 2024

This PR fixes the issue where the client for google.cloud.gkehub_v1beta1 was not being updated automatically.

I followed the steps below to generate the changes in this PR:

  1. Run the commands below in a clone of googleapis/googleapis
bazelisk build //google/cloud/gkehub/v1:gkehub-v1-py
bazelisk build //google/cloud/gkehub/v1/configmanagement:configmanagement-v1-py
bazelisk build //google/cloud/gkehub/v1/multiclusteringress:multiclusteringress-v1v1beta1-py
bazelisk build //google/cloud/gkehub/v1beta1:gkehub-v1beta1-py
  1. Run the command below in a clone of this repository. The docker container will copy code from the bazel-bin directory of googleapis to the owl-bot-staging path specified in .OwlBot.yaml
docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo   -v $HOME/git/googleapis/bazel-bin:/bazel-bin   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin   --source-dir /bazel-bin --dest /repo   --config-file=/packages/google-cloud-gke-hub/.OwlBot.yaml 
  1. Run the command below in a clone of this repository. The docker container will copy the files from owl-bot-staging to the destination path specified in .OwlBot.yaml
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest

Fixes #12323 🦕

@parthea parthea requested a review from a team as a code owner February 16, 2024 12:32
Copy link

snippet-bot bot commented Feb 16, 2024

Here is the summary of changes.

You are about to add 16 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@@ -1,5 +1,5 @@
# -*- coding: utf-8 -*-
# Copyright 2022 Google LLC
# Copyright 2023 Google LLC
Copy link
Contributor Author

@parthea parthea Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this bug to update the copyright year: googleapis/gapic-generator-python#1911

@parthea parthea merged commit 46b7565 into main Feb 16, 2024
18 checks passed
@parthea parthea deleted the update-gkehub-v1beta1 branch February 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prerelease_deps nox session fails for google-cloud-gke-hub
3 participants