Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity.save() should not muck with connection.transaction().add_auto_id() #271

Closed
tseaver opened this issue Oct 20, 2014 · 1 comment
Closed

Entity.save() should not muck with connection.transaction().add_auto_id() #271

tseaver opened this issue Oct 20, 2014 · 1 comment
Assignees
@tseaver
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 20, 2014

This code should be inside 'connection.save_entity()' instead.
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: datastore Issues related to the Datastore API. labels Oct 20, 2014
@tseaver tseaver self-assigned this Oct 20, 2014
@tseaver tseaver added this to the M1: core, datastore & storage milestone Oct 20, 2014
@tseaver tseaver removed their assignment Oct 28, 2014
@tseaver
Copy link
Contributor Author

tseaver commented Oct 28, 2014

I'm going to close this, as I believe a broader fix is needed, as for #303.

@tseaver tseaver closed this as completed Oct 28, 2014
@jgeewax jgeewax modified the milestones: M1: core, datastore & storage, Datastore Stable Jan 30, 2015
urshala pushed a commit to urshala/google-cloud-python that referenced this issue Jan 17, 2020
Enhancement googleapis#271
01ae49d 
Query: Now it's possible to pass attribute=None to the iterable method so you can iterate on the object itself
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 7, 2020
atulep pushed a commit that referenced this issue Apr 6, 2023
@gcf-owl-bot
chore(python): Add kokoro configs for python 3.10 samples testing (#271)
24e5709
atulep pushed a commit that referenced this issue Apr 6, 2023
@gcf-owl-bot
chore(python): Add kokoro configs for python 3.10 samples testing (#271)
9a9d75c
atulep pushed a commit that referenced this issue Apr 18, 2023
@gcf-owl-bot
chore(python): Add kokoro configs for python 3.10 samples testing (#271)
7c9577b
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump cryptography from 38.0.3 to 39.0.1 in /synthtool/gc…
2ee62b1 
…p/templates/python_library/.kokoro (#271)

Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#271)
aa38e34 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea pushed a commit that referenced this issue Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-contact-center-insights t…
2622960 
…o v1.5.0 (#271)
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump cryptography to 41.0.0 [autoapprove] (#271)
529bb0d 
Source-Link: https://togithub.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#271)
78cbd9a 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea added a commit that referenced this issue Jun 4, 2023
@parthea
fix(deps): require google-api-core>=1.32.0,>=2.8.0 (#271)
eb40381 
* fix(deps): require google-api-core>=1.32.0,>=2.8.0

* chore: update constraints
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore: resolve issue with prerelease presubmit [autoapprove] (#271)
6370896 
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): exclude setup.py in renovate config (#271)
2e3dff0 
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea added a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot @parthea
ci(python): run lint / unit tests / docs as GH actions (#271)
dd5a84f 
* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
docs: Update formatting for Purpose class documentation (#271)
60d4a53 
* docs: Update the table format in SearchProjects docs

PiperOrigin-RevId: 528006710

Source-Link: googleapis/googleapis@f373a9c

Source-Link: googleapis/googleapis-gen@28c2158
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjhjMjE1ODhlZGFmMzVjNzNhZjY4YmJiODZkODk3MTNkZTc0OGM3YiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: Update formatting for `Purpose` class documentation

docs: Add documentation for additional acceptable formats for `namespaced_tag_key` and `namespaced_tag_value`in `EffectiveTag`, `parent` in `ListTagKeysRequest`, `parent` in `TagKey`, and `namespaced_name` in `TagValue`
PiperOrigin-RevId: 529262150

Source-Link: googleapis/googleapis@e6c8485

Source-Link: googleapis/googleapis-gen@e3b832f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTNiODMyZmM5MWUwZmI4MzA4YjEzZmQ3MjNmZTgyY2RjODI2ZWI0MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Aug 15, 2023
@renovate-bot
chore(deps): update all dependencies (#271)
d743a85
parthea added a commit that referenced this issue Aug 15, 2023
@gcf-owl-bot @parthea
feat: enable "rest" transport in Python for services supporting numer…
6c87f87 
…ic enums (#271)

* feat: enable "rest" transport in Python for services supporting numeric enums

PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: googleapis/googleapis-gen@6ad1279
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update sync repo settings

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this issue Sep 20, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#271)
0af8d4a 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea pushed a commit that referenced this issue Sep 20, 2023
@gcf-owl-bot
docs: Add documentation for enums (#271)
585167f 
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt [autoa…
971524c 
…pprove] (#271)

Source-Link: https://togithub.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2
parthea added a commit that referenced this issue Sep 22, 2023
@parthea
fix(deps): require protobuf <4.0.0dev (#271)
d8f5a56
parthea added a commit that referenced this issue Sep 22, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#271)
42367da 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this issue Sep 22, 2023
@renovate-bot @parthea
chore(deps): update all dependencies (#271)
50aa917 
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#271)
d9bbb96 
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-scheduler to v2.7.1 (#271)
502c8b1
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: add prerelease nox session (#271)
579d35c 
Source-Link: googleapis/synthtool@050953d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.1 (#271)
541d678
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.62.1 (#271)
532ff31 
- [ ] Regenerate this pull request now.

fix: resolve DuplicateCredentialArgs error when using credentials_file

committer: parthea
PiperOrigin-RevId: 425964861

Source-Link: googleapis/googleapis@84b1a5a

Source-Link: googleapis/googleapis-gen@4fb761b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v2.25.0 (#271)
84368a4
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.2 (#271)
0c61bea
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency cryptography to v37 (#271)
46e159d
parthea added a commit that referenced this issue Oct 21, 2023
@release-please @parthea
chore(main): release 2.9.0 (#271)
49b8e8d 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this issue Oct 21, 2023
@nicain @parthea
Fix: #254 by increasing timeout, use backoff module instead of flaky (#…
0692c9d 
…271)

* feat: use backoff module instead of flaky

* Updates after PR review

Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore(python): add .github/CODEOWNERS as a templated file (#271)
515a50e 
Source-Link: googleapis/synthtool@c5026b3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:0e18b9475fbeb12d9ad4302283171edebb6baf2dfca1bd215ee3b34ed79d95d7

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: update to gapic-generator-python-1.4.2 (#271)
58359e4 
* chore: update to gapic-generator-python-1.4.2 (REST transport test fixes)

PiperOrigin-RevId: 474313212

Source-Link: googleapis/googleapis@cec7333

Source-Link: googleapis/googleapis-gen@47afba9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDdhZmJhOWQzNmI4NGNiYmFhODVkNmUzYmMzNGVmNjVlZmU2MjRlZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: remove 'pip install' statements from python_library templates …
724e198 
…[autoapprove] (#271)

Source-Link: googleapis/synthtool@1f37ce7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore(python): use ubuntu 22.04 in docs image (#271)
392752b 
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
fix: Add async context manager return types (#271)
f8baf1a 
* fix: Add async context manager return types

chore: Mock return_value should not populate oneof message fields

chore: Support snippet generation for services that only support REST transport

chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278

Source-Link: googleapis/googleapis@601b532

Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
chore(python): Add kokoro configs for python 3.10 samples testing (#271)
1333b55
parthea pushed a commit that referenced this issue Oct 22, 2023
@release-please
chore(main): release 1.7.2 (#271)
7fb861d 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 31, 2023
@gcf-owl-bot
docs: Minor formatting (#271)
cf6ed3c 
* docs: Minor formatting
chore: Update gapic-generator-python to v1.11.5
build: Update rules_python to 0.24.0

PiperOrigin-RevId: 563436317

Source-Link: googleapis/googleapis@42fd37b

Source-Link: googleapis/googleapis-gen@280264c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Dec 20, 2024
@gcf-owl-bot
chore(python): update dependencies in .kokoro/docker/docs (#271)
ae66edc 
Source-Link: googleapis/synthtool@e808c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e3e7e18255c22d1489258d0374c901c01f9c4fd77a12088670cd73d580aa737

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgeewax @tseaver @yoshi-automation