Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt split repo: _python-monitoring-dashboards_ #10914

Closed
vchudnov-g opened this issue Apr 4, 2023 · 2 comments
Closed

Adopt split repo: _python-monitoring-dashboards_ #10914

vchudnov-g opened this issue Apr 4, 2023 · 2 comments
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Apr 4, 2023

Migrate the split-repo https://github.com/googleapis/python-monitoring-dashboards to https://github.com/googleapis/google-cloud-python.

The migration readiness criteria are the following, which we track via GitHub labels on this issue. These criteria apply to the split repo we are migrating from:

  • No open issues
  • No open PRs
  • No handwritten samples
  • No system tests
  • No client-specific customizations
@vchudnov-g vchudnov-g added migration:samples:generated Split repo to be migrated here has generated samples migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:library:gapic_auto Library type of the split repo to be migrated here migration:testing:unit Split repo to be migrated here has unit tests migration:issues:open Split repo to be migrated here has open issues when last checked labels Apr 4, 2023
@vchudnov-g vchudnov-g changed the title Adopt split repo: python-monitoring-dashboards Adopt split repo: _python-monitoring-dashboards_ Apr 6, 2023
@vchudnov-g vchudnov-g added the migration:pr:none Split repo to be migrated has no pending PRs label Apr 6, 2023
@parthea
Copy link
Contributor

parthea commented Apr 14, 2023

Resolving the following issue would result in a breaking change for the library: #11858

I'll mark this as blocked for now.

@parthea parthea added the status: blocked Resolving the issue is dependent on other work. label Apr 14, 2023
@parthea parthea added migration:pr:pending Split repo to be migrated has pending PRs migration:pr:none Split repo to be migrated has no pending PRs and removed migration:pr:none Split repo to be migrated has no pending PRs migration:pr:pending Split repo to be migrated has pending PRs labels May 31, 2023
@suztomo
Copy link
Member

suztomo commented Sep 12, 2023

owlbot.py difference:

suztomo@suztomo:/tmp/python-monitoring-dashboards$ git diff -- owlbot.py
diff --git a/owlbot.py b/owlbot.py
index 6354828..ce738f0 100644
--- a/owlbot.py
+++ b/owlbot.py
@@ -35,7 +35,7 @@ for library in s.get_staging_dirs(default_version):
     if clean_up_generated_samples:
         shutil.rmtree("samples/generated_samples", ignore_errors=True)
         clean_up_generated_samples = False
-    s.move([library], excludes=["**/gapic_version.py", "docs/index.rst"])
+    s.move([library], excludes=["**/gapic_version.py"])
 s.remove_staging_dirs()
 
 # ----------------------------------------------------------------------------
@@ -47,10 +47,10 @@ templated_files = gcp.CommonTemplates().py_library(
     microgenerator=True,
     versions=gcp.common.detect_versions(path="./google", default_first=True),
 )
-s.move(templated_files, excludes=[".coveragerc", ".github/release-please.yml", "docs/index.rst"])
+s.move(templated_files, excludes=[".coveragerc", ".github/release-please.yml"])
 
 python.py_samples(skip_readmes=True)
 
 # run format session for all directories which have a noxfile
 for noxfile in Path(".").glob("**/noxfile.py"):
-    s.shell.run(["nox", "-s", "blacken"], cwd=noxfile.parent, hide_output=False)
+    s.shell.run(["nox", "-s", "format"], cwd=noxfile.parent, hide_output=False)

The differences seem to be caused by formatter change in owlbot.py https://gist.github.com/suztomo/000ae1a3ad31d11eecdbb1bf7ca883a7

@parthea parthea added migration:pr:pending Split repo to be migrated has pending PRs and removed migration:pr:none Split repo to be migrated has no pending PRs labels Sep 14, 2023
@parthea parthea added migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:issues:none Split repo to be migrated here had no open issues when last checked and removed status: blocked Resolving the issue is dependent on other work. migration:issues:open Split repo to be migrated here has open issues when last checked migration:pr:pending Split repo to be migrated has pending PRs labels Oct 21, 2023
parthea added a commit that referenced this issue Oct 27, 2023
…boards into packages/google-cloud-monitoring-dashboards (#11901)

See #10914. 

This PR should be merged with a merge-commit, not a squash-commit, in
order to preserve the git history.
@parthea parthea added migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. labels Oct 31, 2023
@parthea parthea closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds
Projects
None yet
Development

No branches or pull requests

3 participants