Fix race condition where pending Ack IDs can be modified by another t…

…hread. (#5929)
googleapis · Sep 12, 2018 · f074335 · f074335
1 parent 001e897
commit f074335
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py b/pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
@@ -379,7 +379,9 @@ def _get_initial_request(self):
         # Any ack IDs that are under lease management need to have their
         # deadline extended immediately.
         if self._leaser is not None:
-            lease_ids = self._leaser.ack_ids
+            # Explicitly copy the list, as it could be modified by another
+            # thread.
+            lease_ids = list(self._leaser.ack_ids)
         else:
             lease_ids = []