Allow setting partition expiration to 'None'. (#6823)

googleapis · Dec 3, 2018 · e9ddb89 · e9ddb89
1 parent 1e8907b
commit e9ddb89
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/bigquery/google/cloud/bigquery/table.py b/bigquery/google/cloud/bigquery/table.py
@@ -1335,7 +1335,10 @@ def expiration_ms(self):
 
     @expiration_ms.setter
     def expiration_ms(self, value):
-        self._properties["expirationMs"] = str(value)
+        if value is not None:
+            # Allow explicitly setting the expiration to None.
+            value = str(value)
+        self._properties["expirationMs"] = value
 
     @property
     def require_partition_filter(self):

diff --git a/bigquery/tests/unit/test_table.py b/bigquery/tests/unit/test_table.py
@@ -1683,3 +1683,8 @@ def test___repr___explicit(self):
             "type=DAY)"
         )
         self.assertEqual(repr(time_partitioning), expected)
+
+    def test_set_expiration_w_none(self):
+        time_partitioning = self._make_one()
+        time_partitioning.expiration_ms = None
+        assert time_partitioning._properties["expirationMs"] is None