Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Re-register debuggee and handle debuggeeId changes #897

Merged
merged 6 commits into from
Feb 13, 2018
Merged

Debugger: Re-register debuggee and handle debuggeeId changes #897

merged 6 commits into from
Feb 13, 2018

Conversation

chingor13
Copy link
Contributor

If the debuggee errors for a reason other than a timeout on the hanging fetch of breakpoints, then we are supposed to re-register the debuggee.

It's also possible that the Stackdriver Debugger service invalidates a debuggee. In this case, the daemon should also re-register itself.

In either case, the debuggeeId could change, so the reporting Agent's background daemon must be resilient to this change. We must provide the debuggeeId along with the breakpoint when reporting.

@chingor13 chingor13 requested a review from tmatsuo as a code owner February 13, 2018 19:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2018
@chingor13 chingor13 merged commit f75fced into googleapis:master Feb 13, 2018
@chingor13 chingor13 deleted the debugger-reregister branch February 13, 2018 21:47
@jdpedrie jdpedrie mentioned this pull request Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants