Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Restructure google-cloud-php #889

Closed
wants to merge 55 commits into from

Conversation

michaelbausor
Copy link
Contributor

WIP PR for visibility.

Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍. A few general comments:

  • We should update the conformance/component directories to match what we have done for Unit, System, etc.
  • Is it worthwhile to move performance and conformance tests into the sub components as well?
  • Have we run the system tests? If not, can spend some time on this today.


require __DIR__ . '/../../vendor/autoload.php';

class ExcludeFilter extends FilterIterator {

This comment was marked as spam.

@@ -0,0 +1,12 @@
{

This comment was marked as spam.

namespace Google\Cloud\Core\Batch;

// Load the autoloader
if (file_exists(__DIR__ . '/../vendor/autoload.php')) {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@@ -0,0 +1,118 @@
<?php

This comment was marked as spam.

@@ -0,0 +1,640 @@
<?php

This comment was marked as spam.

"ext-grpc": "*",
"google/cloud-core": "^1.14",
"google/gax": "^0.30",
"google/proto-client": "^0.32"

This comment was marked as spam.

"minimum-stability": "stable",
"require": {
"google/cloud-core": "^1.14",
"google/proto-client": "^0.32",

This comment was marked as spam.

"erusev/parsedown": "^1.6",
"google/cloud-core": "dev-master as 1.14",
"phpseclib/phpseclib": "^2",
"google/cloud-pubsub": "^0.12"

This comment was marked as spam.

"require": {
"google/proto-client": "^0.33",
"google/gax": "^0.30"
},

This comment was marked as spam.

@@ -35,6 +35,7 @@ public function __construct($currentFile, $content)

public function parse()
{
// echo $this->currentFile;exit;

This comment was marked as spam.

@dwsupplee
Copy link
Contributor

The paths used in the bin keyword of the umbrella package's composer file need to be updated as well: https://github.com/michaelbausor/gcloud-php/blob/ebeee27c1108a94e1f11771882ab37de9139b4a0/composer.json#L155-L156

@michaelbausor
Copy link
Contributor Author

@jdpedrie It looks like doc generation is not working - the google-cloud component is looking too broadly I think, and seeing no docblocks on files that shouldn't be included. I'm not sure what change I have reverted from your commit that I pulled in to make that happen, can you take a look?

@jdpedrie
Copy link
Contributor

jdpedrie commented Mar 5, 2018

@michaelbausor
Copy link
Contributor Author

@jdpedrie great, thanks!


namespace Google\Cloud\Core\Batch;

use Google\Cloud\Core\Daemon\DaemonUtils;

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.


namespace Google\Cloud\Debugger;

use Google\Cloud\Core\Daemon\DaemonUtils;

This comment was marked as spam.

@michaelbausor
Copy link
Contributor Author

The changes in this PR are now available at a branch here: https://github.com/GoogleCloudPlatform/google-cloud-php/tree/restructure-apis

This was referenced Mar 21, 2018
@dwsupplee
Copy link
Contributor

Superseded by #943

@dwsupplee dwsupplee closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants