-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Restructure google-cloud-php #889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍. A few general comments:
- We should update the conformance/component directories to match what we have done for Unit, System, etc.
- Is it worthwhile to move performance and conformance tests into the sub components as well?
- Have we run the system tests? If not, can spend some time on this today.
BigQuery/tests/Snippet/bootstrap.php
Outdated
|
||
require __DIR__ . '/../../vendor/autoload.php'; | ||
|
||
class ExcludeFilter extends FilterIterator { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -0,0 +1,12 @@ | |||
{ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Core/bin/google-cloud-batch
Outdated
namespace Google\Cloud\Core\Batch; | ||
|
||
// Load the autoloader | ||
if (file_exists(__DIR__ . '/../vendor/autoload.php')) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Core/src/Batch/BatchConfig.php
Outdated
@@ -0,0 +1,118 @@ | |||
<?php |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -0,0 +1,640 @@ | |||
<?php |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Spanner/composer.json
Outdated
"ext-grpc": "*", | ||
"google/cloud-core": "^1.14", | ||
"google/gax": "^0.30", | ||
"google/proto-client": "^0.32" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Speech/composer.json
Outdated
"minimum-stability": "stable", | ||
"require": { | ||
"google/cloud-core": "^1.14", | ||
"google/proto-client": "^0.32", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Storage/composer.json
Outdated
"erusev/parsedown": "^1.6", | ||
"google/cloud-core": "dev-master as 1.14", | ||
"phpseclib/phpseclib": "^2", | ||
"google/cloud-pubsub": "^0.12" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
"require": { | ||
"google/proto-client": "^0.33", | ||
"google/gax": "^0.30" | ||
}, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -35,6 +35,7 @@ public function __construct($currentFile, $content) | |||
|
|||
public function parse() | |||
{ | |||
// echo $this->currentFile;exit; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The paths used in the |
@jdpedrie It looks like doc generation is not working - the google-cloud component is looking too broadly I think, and seeing no docblocks on files that shouldn't be included. I'm not sure what change I have reverted from your commit that I pulled in to make that happen, can you take a look? |
@jdpedrie great, thanks! |
Core/bin/google-cloud-batch
Outdated
|
||
namespace Google\Cloud\Core\Batch; | ||
|
||
use Google\Cloud\Core\Daemon\DaemonUtils; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Debugger/bin/google-cloud-debugger
Outdated
|
||
namespace Google\Cloud\Debugger; | ||
|
||
use Google\Cloud\Core\Daemon\DaemonUtils; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The changes in this PR are now available at a branch here: https://github.com/GoogleCloudPlatform/google-cloud-php/tree/restructure-apis |
Superseded by #943 |
WIP PR for visibility.