Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: [Many APIs] migrate php handwritten libraries to new client surface #8069

Closed
wants to merge 2 commits into from

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 4, 2025

  • Regenerate this pull request now.

PiperOrigin-RevId: 722798091

Source-Link: googleapis/googleapis@ae87dc8

Source-Link: https://github.com/googleapis/googleapis-gen/commit/1c83dc19c71a290f063167fdb4b97d8cfab83fe8
Copy-Tag: eyJwIjoiRGVidWdnZXIvLk93bEJvdC55YW1sIiwiaCI6IjFjODNkYzE5YzcxYTI5MGYwNjMxNjdmZGI0Yjk3ZDhjZmFiODNmZTgifQ==
Copy-Tag: eyJwIjoiTGFuZ3VhZ2UvLk93bEJvdC55YW1sIiwiaCI6IjFjODNkYzE5YzcxYTI5MGYwNjMxNjdmZGI0Yjk3ZDhjZmFiODNmZTgifQ==
Copy-Tag: eyJwIjoiU3BlZWNoLy5Pd2xCb3QueWFtbCIsImgiOiIxYzgzZGMxOWM3MWEyOTBmMDYzMTY3ZmRiNGI5N2Q4Y2ZhYjgzZmU4In0=
Copy-Tag: eyJwIjoiVHJhbnNsYXRlLy5Pd2xCb3QueWFtbCIsImgiOiIxYzgzZGMxOWM3MWEyOTBmMDYzMTY3ZmRiNGI5N2Q4Y2ZhYjgzZmU4In0=
Copy-Tag: eyJwIjoiVmlzaW9uLy5Pd2xCb3QueWFtbCIsImgiOiIxYzgzZGMxOWM3MWEyOTBmMDYzMTY3ZmRiNGI5N2Q4Y2ZhYjgzZmU4In0=

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2025
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review February 4, 2025 01:02
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners February 4, 2025 01:02
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 4, 2025
}

return new OperationsClient($options);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the breaking change detector isn't detecting it, this IS a breaking change - the current clients are returning a different class for createOperationsClient, which is exposed to the customer in getOperationsClient.

@bshaffer bshaffer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 6, 2025
@bshaffer
Copy link
Contributor

bshaffer commented Feb 7, 2025

This PR is dependent on the following PRs as well, and then we can bump the major version to V2

NOTE: Once the above PRs are merged, this PR should be empty (because these changes were already generated as a part of them)

@Hectorhammett Hectorhammett changed the title chore!: [Many APIs] migrate php handwritten libraries to new client surface chore: [Many APIs] migrate php handwritten libraries to new client surface Feb 7, 2025
Copy link
Contributor Author

gcf-owl-bot bot commented Feb 7, 2025

Owl bot is regenerating pull request 8069...
Build name: ZWQyNTMyODItODY4MS00YmEyLWExZjUtZjhmMTVlOTlhMzgz

PiperOrigin-RevId: 722798091

Source-Link: googleapis/googleapis@ae87dc8

Source-Link: googleapis/googleapis-gen@1c83dc1
Copy-Tag: eyJwIjoiRGVidWdnZXIvLk93bEJvdC55YW1sIiwiaCI6IjFjODNkYzE5YzcxYTI5MGYwNjMxNjdmZGI0Yjk3ZDhjZmFiODNmZTgifQ==
Copy-Tag: eyJwIjoiTGFuZ3VhZ2UvLk93bEJvdC55YW1sIiwiaCI6IjFjODNkYzE5YzcxYTI5MGYwNjMxNjdmZGI0Yjk3ZDhjZmFiODNmZTgifQ==
Copy-Tag: eyJwIjoiU3BlZWNoLy5Pd2xCb3QueWFtbCIsImgiOiIxYzgzZGMxOWM3MWEyOTBmMDYzMTY3ZmRiNGI5N2Q4Y2ZhYjgzZmU4In0=
Copy-Tag: eyJwIjoiVHJhbnNsYXRlLy5Pd2xCb3QueWFtbCIsImgiOiIxYzgzZGMxOWM3MWEyOTBmMDYzMTY3ZmRiNGI5N2Q4Y2ZhYjgzZmU4In0=
Copy-Tag: eyJwIjoiVmlzaW9uLy5Pd2xCb3QueWFtbCIsImgiOiIxYzgzZGMxOWM3MWEyOTBmMDYzMTY3ZmRiNGI5N2Q4Y2ZhYjgzZmU4In0=
@gcf-owl-bot gcf-owl-bot bot changed the title chore: [Many APIs] migrate php handwritten libraries to new client surface chore!: [Many APIs] migrate php handwritten libraries to new client surface Feb 7, 2025
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-5482bf4b24561fda7eb1 branch from 7d91410 to 788d3ad Compare February 7, 2025 21:52
Copy link

snippet-bot bot commented Feb 7, 2025

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2025
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2025
@gcf-owl-bot gcf-owl-bot bot closed this Feb 7, 2025
@gcf-owl-bot gcf-owl-bot bot deleted the owl-bot-copy-5482bf4b24561fda7eb1 branch February 7, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant