Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Dataproc] add resource reference for KMS keys and fix comments #7671

Merged
merged 2 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Dataproc/metadata/V1/Clusters.php
Binary file not shown.
Binary file modified Dataproc/metadata/V1/Shared.php
Binary file not shown.
Binary file modified Dataproc/metadata/V1/WorkflowTemplates.php
Binary file not shown.
32 changes: 16 additions & 16 deletions Dataproc/src/V1/AcceleratorConfig.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions Dataproc/src/V1/Client/ClusterControllerClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,27 @@ public static function clusterRegionName(string $project, string $region, string
]);
}

/**
* Formats a string containing the fully-qualified path to represent a crypto_key
* resource.
*
* @param string $project
* @param string $location
* @param string $keyRing
* @param string $cryptoKey
*
* @return string The formatted crypto_key resource.
*/
public static function cryptoKeyName(string $project, string $location, string $keyRing, string $cryptoKey): string
{
return self::getPathTemplate('cryptoKey')->render([
'project' => $project,
'location' => $location,
'key_ring' => $keyRing,
'crypto_key' => $cryptoKey,
]);
}

/**
* Formats a string containing the fully-qualified path to represent a node_group
* resource.
Expand Down Expand Up @@ -260,6 +281,7 @@ public static function serviceName(string $project, string $location, string $se
* Template: Pattern
* - cluster: projects/{project}/locations/{location}/clusters/{cluster}
* - clusterRegion: projects/{project}/regions/{region}/clusters/{cluster}
* - cryptoKey: projects/{project}/locations/{location}/keyRings/{key_ring}/cryptoKeys/{crypto_key}
* - nodeGroup: projects/{project}/regions/{region}/clusters/{cluster}/nodeGroups/{node_group}
* - service: projects/{project}/locations/{location}/services/{service}
*
Expand Down
22 changes: 22 additions & 0 deletions Dataproc/src/V1/Client/WorkflowTemplateServiceClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,27 @@ public static function clusterRegionName(string $project, string $region, string
]);
}

/**
* Formats a string containing the fully-qualified path to represent a crypto_key
* resource.
*
* @param string $project
* @param string $location
* @param string $keyRing
* @param string $cryptoKey
*
* @return string The formatted crypto_key resource.
*/
public static function cryptoKeyName(string $project, string $location, string $keyRing, string $cryptoKey): string
{
return self::getPathTemplate('cryptoKey')->render([
'project' => $project,
'location' => $location,
'key_ring' => $keyRing,
'crypto_key' => $cryptoKey,
]);
}

/**
* Formats a string containing the fully-qualified path to represent a location
* resource.
Expand Down Expand Up @@ -335,6 +356,7 @@ public static function workflowTemplateName(string $project, string $region, str
* The following name formats are supported:
* Template: Pattern
* - clusterRegion: projects/{project}/regions/{region}/clusters/{cluster}
* - cryptoKey: projects/{project}/locations/{location}/keyRings/{key_ring}/cryptoKeys/{crypto_key}
* - location: projects/{project}/locations/{location}
* - nodeGroup: projects/{project}/regions/{region}/clusters/{cluster}/nodeGroups/{node_group}
* - projectLocationWorkflowTemplate: projects/{project}/locations/{location}/workflowTemplates/{workflow_template}
Expand Down
9 changes: 5 additions & 4 deletions Dataproc/src/V1/Component.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Dataproc/src/V1/DiagnoseClusterRequest.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 23 additions & 11 deletions Dataproc/src/V1/EncryptionConfig.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Dataproc/src/V1/FlinkJob.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading