Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Profiler] add start_time to Profile proto #7092

Merged
merged 2 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Profiler/metadata/V2/Profiler.php
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,14 @@
use Google\Cloud\Profiler\V2\Profile;

/**
* CreateOfflineProfile creates a new profile resource in the offline mode.
* The client provides the profile to create along with the profile bytes, the
* server records it.
* CreateOfflineProfile creates a new profile resource in the offline
* mode. The client provides the profile to create along with the profile
* bytes, the server records it.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* This sample has been automatically generated and should be regarded as a code
* template only. It will require modifications to work:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
/**
* CreateProfile creates a new profile resource in the online mode.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* The server ensures that the new profiles are created at a constant rate per
* deployment, so the creation request may hang for some time until the next
* profile session is available.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@
* offline mode is currently not supported: the profile content must be
* provided at the time of the profile creation.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* This sample has been automatically generated and should be regarded as a code
* template only. It will require modifications to work:
* - It may require correct/in-range values for request initialization.
Expand Down
26 changes: 20 additions & 6 deletions Profiler/src/V2/Client/ProfilerServiceClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,8 @@
* Service Description: Manage the collection of continuous profiling data provided by profiling
* agents running in the cloud or by an offline provider of profiling data.
*
* General guidelines:
* * Profiles for a single deployment must be created in ascending time order.
* * Profiles can be created in either online or offline mode, see below.
* __The APIs listed in this service are intended for use within our profiler
* agents only.__
*
* This class provides the ability to make remote calls to the backing service through method
* calls that map to API methods.
Expand Down Expand Up @@ -237,9 +236,14 @@ public function __call($method, $args)
}

/**
* CreateOfflineProfile creates a new profile resource in the offline mode.
* The client provides the profile to create along with the profile bytes, the
* server records it.
* CreateOfflineProfile creates a new profile resource in the offline
* mode. The client provides the profile to create along with the profile
* bytes, the server records it.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* The async variant is {@see ProfilerServiceClient::createOfflineProfileAsync()} .
*
Expand Down Expand Up @@ -267,6 +271,11 @@ public function createOfflineProfile(CreateOfflineProfileRequest $request, array
/**
* CreateProfile creates a new profile resource in the online mode.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* The server ensures that the new profiles are created at a constant rate per
* deployment, so the creation request may hang for some time until the next
* profile session is available.
Expand Down Expand Up @@ -309,6 +318,11 @@ public function createProfile(CreateProfileRequest $request, array $callOptions
* offline mode is currently not supported: the profile content must be
* provided at the time of the profile creation.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* The async variant is {@see ProfilerServiceClient::updateProfileAsync()} .
*
* @example samples/V2/ProfilerServiceClient/update_profile.php
Expand Down
26 changes: 20 additions & 6 deletions Profiler/src/V2/Gapic/ProfilerServiceGapicClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,8 @@
* Service Description: Manage the collection of continuous profiling data provided by profiling
* agents running in the cloud or by an offline provider of profiling data.
*
* General guidelines:
* * Profiles for a single deployment must be created in ascending time order.
* * Profiles can be created in either online or offline mode, see below.
* __The APIs listed in this service are intended for use within our profiler
* agents only.__
*
* This class provides the ability to make remote calls to the backing service through method
* calls that map to API methods. Sample code to get started:
Expand Down Expand Up @@ -287,9 +286,14 @@ public function __construct(array $options = [])
}

/**
* CreateOfflineProfile creates a new profile resource in the offline mode.
* The client provides the profile to create along with the profile bytes, the
* server records it.
* CreateOfflineProfile creates a new profile resource in the offline
* mode. The client provides the profile to create along with the profile
* bytes, the server records it.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* Sample code:
* ```
Expand Down Expand Up @@ -339,6 +343,11 @@ public function createOfflineProfile(array $optionalArgs = [])
/**
* CreateProfile creates a new profile resource in the online mode.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* The server ensures that the new profiles are created at a constant rate per
* deployment, so the creation request may hang for some time until the next
* profile session is available.
Expand Down Expand Up @@ -410,6 +419,11 @@ public function createProfile(array $optionalArgs = [])
* offline mode is currently not supported: the profile content must be
* provided at the time of the profile creation.
*
* _Direct use of this API is discouraged, please use a [supported
* profiler
* agent](https://cloud.google.com/profiler/docs/about-profiler#profiling_agent)
* instead for profile collection._
*
* Sample code:
* ```
* $profilerServiceClient = new ProfilerServiceClient();
Expand Down
23 changes: 19 additions & 4 deletions Profiler/src/V2/ListProfilesRequest.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 48 additions & 0 deletions Profiler/src/V2/Profile.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading