Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PubSub] add enforce_in_transit fields and optional annotations #6998

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat: [PubSub] add enforce_in_transit fields and optional annotations #6998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
850bdf9
feat: add enforce_in_transit fields and optional annotations
gcf-owl-bot[bot] Jan 24, 2024
7416131
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified PubSub/metadata/V1/Pubsub.php
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions PubSub/samples/V1/PublisherClient/update_topic.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
use Google\Protobuf\FieldMask;

/**
* Updates an existing topic. Note that certain properties of a
* topic are not modifiable.
* Updates an existing topic by updating the fields specified in the update
* mask. Note that certain properties of a topic are not modifiable.
*
* @param string $topicName The name of the topic. It must have the format
* `"projects/{project}/topics/{topic}"`. `{topic}` must start with a letter,
Expand Down
3 changes: 2 additions & 1 deletion PubSub/samples/V1/SubscriberClient/modify_ack_deadline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
* delivery to another subscriber client. This typically results in an
* increase in the rate of message redeliveries (that is, duplicates).
* The minimum deadline you can specify is 0 seconds.
* The maximum deadline you can specify is 600 seconds (10 minutes).
* The maximum deadline you can specify in a single request is 600 seconds
* (10 minutes).
*/
function modify_ack_deadline_sample(
string $formattedSubscription,
Expand Down
3 changes: 2 additions & 1 deletion PubSub/samples/V1/SubscriberClient/update_snapshot.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
use Google\Protobuf\FieldMask;

/**
* Updates an existing snapshot. Snapshots are used in
* Updates an existing snapshot by updating the fields specified in the update
* mask. Snapshots are used in
* [Seek](https://cloud.google.com/pubsub/docs/replay-overview) operations,
* which allow you to manage message acknowledgments in bulk. That is, you can
* set the acknowledgment state of messages in an existing subscription to the
Expand Down
5 changes: 3 additions & 2 deletions PubSub/samples/V1/SubscriberClient/update_subscription.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@
use Google\Protobuf\FieldMask;

/**
* Updates an existing subscription. Note that certain properties of a
* subscription, such as its topic, are not modifiable.
* Updates an existing subscription by updating the fields specified in the
* update mask. Note that certain properties of a subscription, such as its
* topic, are not modifiable.
*
* @param string $subscriptionName The name of the subscription. It must have the format
* `"projects/{project}/subscriptions/{subscription}"`. `{subscription}` must
Expand Down
66 changes: 33 additions & 33 deletions PubSub/src/V1/BigQueryConfig.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions PubSub/src/V1/BigQueryConfig/State.php
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions PubSub/src/V1/Client/PublisherClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,8 @@ public function publish(PublishRequest $request, array $callOptions = []): Publi
}

/**
* Updates an existing topic. Note that certain properties of a
* topic are not modifiable.
* Updates an existing topic by updating the fields specified in the update
* mask. Note that certain properties of a topic are not modifiable.
*
* The async variant is {@see PublisherClient::updateTopicAsync()} .
*
Expand Down
8 changes: 5 additions & 3 deletions PubSub/src/V1/Client/SubscriberClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,8 @@ public function streamingPull(array $callOptions = []): BidiStream
}

/**
* Updates an existing snapshot. Snapshots are used in
* Updates an existing snapshot by updating the fields specified in the update
* mask. Snapshots are used in
* [Seek](https://cloud.google.com/pubsub/docs/replay-overview) operations,
* which allow you to manage message acknowledgments in bulk. That is, you can
* set the acknowledgment state of messages in an existing subscription to the
Expand Down Expand Up @@ -786,8 +787,9 @@ public function updateSnapshot(UpdateSnapshotRequest $request, array $callOption
}

/**
* Updates an existing subscription. Note that certain properties of a
* subscription, such as its topic, are not modifiable.
* Updates an existing subscription by updating the fields specified in the
* update mask. Note that certain properties of a subscription, such as its
* topic, are not modifiable.
*
* The async variant is {@see SubscriberClient::updateSubscriptionAsync()} .
*
Expand Down
Loading
Loading