Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PubSub): Add CloudStorageConfig to subscribe function #6482

Merged
merged 7 commits into from
Aug 2, 2023
Merged

feat(PubSub): Add CloudStorageConfig to subscribe function #6482

merged 7 commits into from
Aug 2, 2023

Conversation

ajupazhamayil
Copy link
Contributor

@ajupazhamayil ajupazhamayil commented Jul 24, 2023 •
edited by vishwarajanand
Loading

@ajupazhamayil ajupazhamayil requested review from a team as code owners July 24, 2023 18:40
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jul 24, 2023
@ajupazhamayil ajupazhamayil mentioned this pull request Jul 24, 2023
Closed
vishwarajanand
vishwarajanand reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, left a few nits

yash30201
yash30201 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@yash30201 yash30201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yash30201 yash30201 merged commit bcb075f into main Aug 2, 2023
@yash30201 yash30201 deleted the cpsToGcsTemp branch August 2, 2023 10:58
@release-please release-please bot mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash30201 yash30201 yash30201 approved these changes

@vishwarajanand vishwarajanand Awaiting requested review from vishwarajanand

@lahuang4 lahuang4 Awaiting requested review from lahuang4

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajupazhamayil @vishwarajanand @yash30201