-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [Build] fix proto formatting #5639
Conversation
Here is the summary of possible violations 😱 There are 2 possible violations for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
||
require_once __DIR__ . '/../../../vendor/autoload.php'; | ||
|
||
// [START buildeventservice_v1_generated_PublishBuildEvent_PublishBuildToolEventStream_sync] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to investigate the product name (would think this should be build
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what happened, when we updated to owlbot we used the following source:
google-cloud-php/Build/.OwlBot.yaml
Line 2 in 2cc2210
- source: /google/devtools/build/v1/.*-php/(.*) |
It should be:
source: /google/devtools/cloudbuild/v1/.*-php/(.*)
tldr: the source is buildeventservice and not cloudbuild
Owl bot is regenerating pull request 5639... |
PiperOrigin-RevId: 490003667 Source-Link: googleapis/googleapis@b6b7514 Source-Link: googleapis/googleapis-gen@f11251a Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6ImYxMTI1MWE0MjljNjE3OTI3OWQzNDA2NjUwY2ZkZDJhMDkxMTg2ZWIifQ==
224f447
to
3e4fef8
Compare
PiperOrigin-RevId: 493134713 Source-Link: googleapis/googleapis@83d92bd Source-Link: googleapis/googleapis-gen@223117b Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6IjIyMzExN2I3MmFmMTJjNmI5YWI2MTFmMzEwNzI5YzNhMmY0OTNmMmYifQ==
docs: minor update in comments PiperOrigin-RevId: 494835140 Source-Link: googleapis/googleapis@e8356fe Source-Link: googleapis/googleapis-gen@cdd533a Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6ImNkZDUzM2E3Y2UwNTcyMWZjN2Q3OWU2YWMzOWY5YzhmMmJlM2JmMWUifQ==
PiperOrigin-RevId: 499263614 Source-Link: googleapis/googleapis@ba2db0d Source-Link: googleapis/googleapis-gen@503d1e8 Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6IjUwM2QxZThlZmYwNDUzNWZjNWQ0Yjc0ZmUxYzg5NGU2N2ZkNTk2YjIifQ==
PiperOrigin-RevId: 503177089 Source-Link: googleapis/googleapis@1ccd54b Source-Link: googleapis/googleapis-gen@537cd79 Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6IjUzN2NkNzlkOWM3MzllNDg3YjdhNDEyMzljMWI5MmY1YjBiYzA4MGUifQ==
Closing, as this updates the wrong package |
PiperOrigin-RevId: 503177089
Source-Link: googleapis/googleapis@1ccd54b
Source-Link: https://github.com/googleapis/googleapis-gen/commit/537cd79d9c739e487b7a41239c1b92f5b0bc080e
Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6IjUzN2NkNzlkOWM3MzllNDg3YjdhNDEyMzljMWI5MmY1YjBiYzA4MGUifQ==
BEGIN_NESTED_COMMIT
feat: [Build] Add location methods
PiperOrigin-RevId: 499263614
Source-Link: googleapis/googleapis@ba2db0d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/503d1e8eff04535fc5d4b74fe1c894e67fd596b2
Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6IjUwM2QxZThlZmYwNDUzNWZjNWQ0Yjc0ZmUxYzg5NGU2N2ZkNTk2YjIifQ==
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [Build] added field BuildStatus.error_message
docs: minor update in comments
PiperOrigin-RevId: 494835140
Source-Link: googleapis/googleapis@e8356fe
Source-Link: https://github.com/googleapis/googleapis-gen/commit/cdd533a7ce05721fc7d79e6ac39f9c8f2be3bf1e
Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6ImNkZDUzM2E3Y2UwNTcyMWZjN2Q3OWU2YWMzOWY5YzhmMmJlM2JmMWUifQ==
END_NESTED_COMMITBEGIN_NESTED_COMMITchore(bazel): [Build] update gapic-generator-php to v1.6.2
PiperOrigin-RevId: 493134713
Source-Link: googleapis/googleapis@83d92bd
Source-Link: https://github.com/googleapis/googleapis-gen/commit/223117b72af12c6b9ab611f310729c3a2f493f2f
Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6IjIyMzExN2I3MmFmMTJjNmI5YWI2MTFmMzEwNzI5YzNhMmY0OTNmMmYifQ==
END_NESTED_COMMITBEGIN_NESTED_COMMITdocs: [Build] fix typo in docstring
PiperOrigin-RevId: 490003667
Source-Link: googleapis/googleapis@b6b7514
Source-Link: https://github.com/googleapis/googleapis-gen/commit/f11251a429c6179279d3406650cfdd2a091186eb
Copy-Tag: eyJwIjoiQnVpbGQvLk93bEJvdC55YW1sIiwiaCI6ImYxMTI1MWE0MjljNjE3OTI3OWQzNDA2NjUwY2ZkZDJhMDkxMTg2ZWIifQ==
END_NESTED_COMMIT