Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Added stream_set_option in StreamWrapper #5067

Merged
merged 6 commits into from
Jan 27, 2022
Merged

fix(storage): Added stream_set_option in StreamWrapper #5067

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1feb798
Added stream_set_option in Google\Cloud\Storage\StreamWrapper to avoi…
saranshdhingra Jan 27, 2022
4f810cf
fix(storage): Added stream_set_option in StreamWrapper to avoid warni…
saranshdhingra Jan 27, 2022
c9ad3a2
Merge branch 'gcs-set-stream-option' of https://github.com/saranshdhi…
saranshdhingra Jan 27, 2022
e00c0b7
fix(storage): Removed unused static class property in StreamWrapper
saranshdhingra Jan 27, 2022
d2ec1f2
fix(storage): composer.json cleanup.
saranshdhingra Jan 27, 2022
67d4917
fix(Storgae): Lint fixes
saranshdhingra Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Storage/src/StreamWrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,16 @@ public function __destruct()
$this->stream_close();
}

/**
* Starting PHP 7.4, this is called when include/require is used on a stream.
* Absence of this method presents a warning.
* https://www.php.net/manual/en/migration74.incompatible.php
*/
public function stream_set_option()
{
return false;
}

/**
* Register a StreamWrapper for reading and writing to Google Storage
*
Expand Down