fix: add missing KMS resource name method in post-processing #5043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatsuo
reviewed
Jan 21, 2022
Kms/owlbot.py
Outdated
|
|
||
| s.replace( | ||
| 'src/V1/Gapic/KeyManagementServiceGapicClient.php', | ||
| r"}", |
There was a problem hiding this comment.
This operation is not idempotent.
Can you grep the new function name and if it doesn't exist inject it?
There was a problem hiding this comment.
great idea! Is there a grep functionality in synthtool, or should I just implement it in python like this
f = open('src/V1/Gapic/KeyManagementServiceGapicClient.php', "r")
if 'public static function cryptoKeyName' not in f.read():
s.replace(..)There was a problem hiding this comment.
Okay, implemented in latest change. PTAL!
1 task
tmatsuo
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.