Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE ME] Re-generated SecurityCenter to pick up changes in the API or client library generator. #2511

Closed
wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Log from Synthtool
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/SecurityCenter/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/securitycenter/artman_securitycenter_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-securitycenter-v1.
synthtool > No files in sources /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-securitycenter-v1/proto/src/GPBMetadata/Google/Cloud/SecurityCenter were copied. Does the source contain files?
synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/SecurityCenterGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1/Gapic/SecurityCenterGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/SecurityCenterGapicClient.php.
synthtool > Replaced 'final class' in src/V1/ListFindingsRequest.php.
synthtool > Replaced 'final class' in src/V1/GroupFindingsResponse.php.
synthtool > Replaced 'final class' in src/V1/ListSourcesRequest.php.
synthtool > Replaced 'final class' in src/V1/Source.php.
synthtool > Replaced 'final class' in src/V1/ListSourcesResponse.php.
synthtool > Replaced 'final class' in src/V1/Asset.php.
synthtool > Replaced 'final class' in src/V1/RunAssetDiscoveryResponse.php.
synthtool > Replaced 'final class' in src/V1/UpdateFindingRequest.php.
synthtool > Replaced 'final class' in src/V1/SetFindingStateRequest.php.
synthtool > Replaced 'final class' in src/V1/SecurityMarks.php.
synthtool > Replaced 'final class' in src/V1/ListAssetsRequest.php.
synthtool > Replaced 'final class' in src/V1/GroupAssetsRequest.php.
synthtool > Replaced 'final class' in src/V1/GetSourceRequest.php.
synthtool > Replaced 'final class' in src/V1/CreateFindingRequest.php.
synthtool > Replaced 'final class' in src/V1/CreateSourceRequest.php.
synthtool > Replaced 'final class' in src/V1/OrganizationSettings.php.
synthtool > Replaced 'final class' in src/V1/GroupAssetsResponse.php.
synthtool > Replaced 'final class' in src/V1/UpdateSourceRequest.php.
synthtool > Replaced 'final class' in src/V1/Finding.php.
synthtool > Replaced 'final class' in src/V1/GroupFindingsRequest.php.
synthtool > Replaced 'final class' in src/V1/ListAssetsResponse.php.
synthtool > Replaced 'final class' in src/V1/GroupResult.php.
synthtool > Replaced 'final class' in src/V1/ListFindingsResponse.php.
synthtool > Replaced 'final class' in src/V1/UpdateSecurityMarksRequest.php.
synthtool > Replaced 'final class' in src/V1/GetOrganizationSettingsRequest.php.
synthtool > Replaced 'final class' in src/V1/RunAssetDiscoveryRequest.php.
synthtool > Replaced 'final class' in src/V1/UpdateOrganizationSettingsRequest.php.
synthtool > Replaced 'final class' in src/V1/ListFindingsResponse/ListFindingsResult.php.
synthtool > Replaced 'final class' in src/V1/OrganizationSettings/AssetDiscoveryConfig.php.
synthtool > Replaced 'final class' in src/V1/Asset/SecurityCenterProperties.php.
synthtool > Replaced 'final class' in src/V1/Asset/IamPolicy.php.
synthtool > Replaced 'final class' in src/V1/ListAssetsResponse/ListAssetsResult.php.
synthtool > No replacements made in src/V*/**/*.php for pattern public function ([s|g]\w{3,})Unwrapped, maybe replacement is not longer needed?
synthtool > Replaced 'Copyright \\d{4}' in src/V1/SecurityCenterClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/SecurityCenterGrpcClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SecurityCenterGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SecurityCenterClientTest.php.
synthtool > No replacements made in src/V1/Gapic/SecurityCenterGapicClient.php for pattern Finding_State, maybe replacement is not longer needed?
synthtool > Replaced 'will be removed in the next major release' in src/V1/ListAssetsResponse_ListAssetsResult_StateChange.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/ListFindingsResponse_ListFindingsResult.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/OrganizationSettings_AssetDiscoveryConfig.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/RunAssetDiscoveryResponse_State.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/OrganizationSettings_AssetDiscoveryConfig_InclusionMode.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/Asset_SecurityCenterProperties.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/Asset_IamPolicy.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/ListFindingsResponse_ListFindingsResult_StateChange.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/Finding_State.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/ListAssetsResponse_ListAssetsResult.php.
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: securitycenter Issues related to the Security Command Center API. label Dec 10, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@@ -226,52 +226,5 @@
],
],
],
'google.longrunning.Operations' => [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwsupplee I still see Operations used in this client. Think we need to add these bindings back?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks like we do. There is an issue upstream that has been stripping out these operation bindings. For now, would you be able to help patch these back in with synthtool or something similar?

@jdpedrie jdpedrie added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 10, 2019
@jdpedrie jdpedrie closed this Jan 15, 2020
@jdpedrie jdpedrie deleted the autosynth-securitycenter branch January 15, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: securitycenter Issues related to the Security Command Center API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants