Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update googleapis.com -> storage.googleapis.com #2426

Merged
merged 1 commit into from
Oct 28, 2019
Merged

feat: update googleapis.com -> storage.googleapis.com #2426

merged 1 commit into from
Oct 28, 2019

Conversation

dwsupplee
Copy link
Contributor

No description provided.

@dwsupplee dwsupplee added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. labels Oct 25, 2019
@dwsupplee dwsupplee requested review from jdpedrie and frankyn October 25, 2019 23:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2019
frankyn
frankyn approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after tests pass and release Monday as discussed offline. Thanks @dwsupplee for the fast turnaround on this request and your patience!

@codecov
Copy link

codecov bot commented Oct 26, 2019 •
edited
Loading

Codecov Report

Merging #2426 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2426   +/-   ##
=========================================
  Coverage     92.55%   92.55%           
  Complexity     4504     4504           
=========================================
  Files           312      312           
  Lines         13496    13496           
=========================================
  Hits          12491    12491           
  Misses         1005     1005
Impacted Files Coverage Δ Complexity Δ
Storage/src/Connection/Rest.php 100% <ø> (ø) 58 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b90be0...a04918d. Read the comment docs.

@frankyn
Copy link
Member

frankyn commented Oct 28, 2019

Tests pass. please merge/release when ready.

@dwsupplee dwsupplee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2019
jdpedrie
jdpedrie reviewed Oct 28, 2019
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jdpedrie
jdpedrie approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwsupplee dwsupplee merged commit 3c6266c into googleapis:master Oct 28, 2019
This was referenced Jan 15, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Closed
Closed
Merged
Closed
This was referenced Feb 4, 2020
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwsupplee @frankyn @jdpedrie @googlebot