Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: **BREAKING** Ensure operations calls work correctly. #2379

Merged
merged 3 commits into from
Oct 7, 2019
Merged

fix: **BREAKING** Ensure operations calls work correctly. #2379

merged 3 commits into from
Oct 7, 2019

Conversation

dwsupplee
Copy link
Contributor

It looks like the operations.proto file was missing when we generated and has since been added.

@dwsupplee dwsupplee added the api: automl Issues related to the AutoML API. label Oct 7, 2019
@dwsupplee dwsupplee requested a review from jdpedrie October 7, 2019 18:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2019
@codecov
Copy link

codecov bot commented Oct 7, 2019 •
edited
Loading

Codecov Report

Merging #2379 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2379   +/-   ##
=========================================
  Coverage     92.55%   92.55%           
  Complexity     4503     4503           
=========================================
  Files           312      312           
  Lines         13497    13497           
=========================================
  Hits          12492    12492           
  Misses         1005     1005

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30dea94...0daa5c4. Read the comment docs.

jdpedrie
jdpedrie reviewed Oct 7, 2019
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dwsupplee dwsupplee changed the title fix: Ensure operations calls work correctly fix: **BREAKING** Ensure operations calls work correctly. Oct 7, 2019
@jdpedrie jdpedrie merged commit 45dc25b into googleapis:master Oct 7, 2019
@jdpedrie jdpedrie deleted the automl-fixes branch October 7, 2019 20:06
This was referenced Jan 16, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Closed
Closed
Merged
Merged
@yoshi-automation yoshi-automation mentioned this pull request Feb 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: automl Issues related to the AutoML API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwsupplee @jdpedrie @googlebot