-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce Cloud AutoML V1 client #2367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks @sirtorry :). A few high level notes after glancing through:
- It looks like we need to make sure the php_namespace option is updated in the various AutoML proto files (for example: https://github.com/googleapis/googleapis/blob/master/google/cloud/automl/v1/service.proto#L35). It should be
AutoMl
notAutoML
. I can help with this if need be, just let me know. - We should also update the main README (https://github.com/sirtorry/google-cloud-php/blob/automl-v1/README.md#cloud-automl-beta)
- I thought a smoke test would be autogenerated, but it looks like it wasn't. Would we be able to add one? It should look just like this.
For the smoke test, I copied from v1beta1. |
Codecov Report
@@ Coverage Diff @@
## master #2367 +/- ##
=========================================
Coverage ? 92.55%
Complexity ? 4503
=========================================
Files ? 312
Lines ? 13497
Branches ? 0
=========================================
Hits ? 12492
Misses ? 1005
Partials ? 0 Continue to review full report at Codecov.
|
No description provided.