Only throw exception when creating directory really failed in HandleFailureTrait #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailureTrait When multiple processes try to create a directory at the same time `mkdir` is going to fail and return false. This should not warrant an exception. This change ensures the directory exists - and only throws when it does not.
googlebot
added
the
cla: yes
jdpedrie
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #2341 +/- ##
============================================
- Coverage 92.49% 92.49% -0.01%
- Complexity 4479 4480 +1
============================================
Files 311 311
Lines 13358 13357 -1
============================================
- Hits 12355 12354 -1
Misses 1003 1003
Continue to review full report at Codecov.
|
This was referenced Jan 15, 2020
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple processes try to create a directory at the same time
mkdiris going to fail and return false. This should not warrant an exception.This change ensures the directory exists - and only throws when it does not.