Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rollback #2268 #2271

Merged
merged 1 commit into from
Aug 27, 2019
Merged

docs: Rollback #2268 #2271

merged 1 commit into from
Aug 27, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/Talent/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
0.29.1: Pulling from googleapis/artman
Digest: sha256:b2a73f4dda03ef8fcaa973e3ba26d0cf34091f6c22c70add663af325931aef4d
Status: Image is up to date for googleapis/artman:0.29.1
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/talent/artman_talent_v4beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-talent-v4beta1.
synthtool > Replaced "'serviceAddress' =>" in src/V4beta1/Gapic/EventServiceGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V4beta1/Gapic/TenantServiceGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V4beta1/Gapic/ProfileServiceGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V4beta1/Gapic/JobServiceGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V4beta1/Gapic/CompanyServiceGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V4beta1/Gapic/CompletionGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V4beta1/Gapic/ApplicationServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V4beta1/Gapic/EventServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V4beta1/Gapic/TenantServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V4beta1/Gapic/ProfileServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V4beta1/Gapic/JobServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V4beta1/Gapic/CompanyServiceGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V4beta1/Gapic/CompletionGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V4beta1/Gapic/ApplicationServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V4beta1/Gapic/EventServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V4beta1/Gapic/TenantServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V4beta1/Gapic/ProfileServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V4beta1/Gapic/JobServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V4beta1/Gapic/CompanyServiceGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V4beta1/Gapic/CompletionGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V4beta1/Gapic/ApplicationServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V4beta1/Gapic/EventServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V4beta1/Gapic/TenantServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V4beta1/Gapic/ProfileServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V4beta1/Gapic/JobServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V4beta1/Gapic/CompanyServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V4beta1/Gapic/ResumeServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V4beta1/Gapic/CompletionGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V4beta1/Gapic/ApplicationServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V4beta1/ResumeServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V4beta1/TenantServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V4beta1/EventServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V4beta1/ProfileServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V4beta1/JobServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V4beta1/CompanyServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V4beta1/ApplicationServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V4beta1/CompletionClientTest.php.
synthtool > No replacements made in src/V4beta1/Gapic/*.php for pattern CompleteQueryRequest_, maybe replacement is not longer needed?
synthtool > No replacements made in src/V4beta1/Gapic/*.php for pattern SearchJobsRequest_, maybe replacement is not longer needed?
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: talent talent.googleapis.com (DO NOT CHANGE LABEL NAME) label Aug 27, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #2271 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2271   +/-   ##
========================================
  Coverage      92.6%   92.6%           
  Complexity     4467    4467           
========================================
  Files           307     307           
  Lines         13323   13323           
========================================
  Hits          12338   12338           
  Misses          985     985
Impacted Files Coverage Δ Complexity Δ
Storage/src/StorageObject.php 100% <0%> (ø) 38% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 654b974...4f2ca58. Read the comment docs.

@jdpedrie
Copy link
Contributor

#2263
#2268

This keeps getting deployed then rolled back.

@jdpedrie jdpedrie added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2019
@dwsupplee dwsupplee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2019
@dwsupplee
Copy link
Contributor

This should be the last related change we see here, the protos got rolled back recently. We should be good to merge.

@dwsupplee dwsupplee changed the title [CHANGE ME] Re-generated Talent to pick up changes in the API or client library generator. docs: Rollback #2268 Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: talent talent.googleapis.com (DO NOT CHANGE LABEL NAME) cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants