Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DeadLetterPolicy support. #2260

Merged
merged 1 commit into from
Aug 26, 2019
Merged

feat: Add DeadLetterPolicy support. #2260

merged 1 commit into from
Aug 26, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/PubSub/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
0.29.1: Pulling from googleapis/artman
Digest: sha256:b2a73f4dda03ef8fcaa973e3ba26d0cf34091f6c22c70add663af325931aef4d
Status: Image is up to date for googleapis/artman:0.29.1
synthtool > Cloning googleapis.
synthtool > Running generator for google/pubsub/artman_pubsub.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-pubsub-v1.
synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/SubscriberGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/PublisherGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1/Gapic/SubscriberGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1/Gapic/PublisherGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/SubscriberGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/PublisherGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SubscriberGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/PublisherGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/PublisherClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/PublisherGrpcClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/SubscriberClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/SubscriberGrpcClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/PublisherSmokeTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SubscriberClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/PublisherClientTest.php.
synthtool > No replacements made in src/**/*.php for pattern <a href="/pubsub/docs/, maybe replacement is not longer needed?
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: pubsub Issues related to the Pub/Sub API. label Aug 22, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #2260 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2260   +/-   ##
========================================
  Coverage      92.6%   92.6%           
  Complexity     4467    4467           
========================================
  Files           307     307           
  Lines         13323   13323           
========================================
  Hits          12338   12338           
  Misses          985     985

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0668faa...16cf2a8. Read the comment docs.

@jdpedrie jdpedrie changed the title [CHANGE ME] Re-generated PubSub to pick up changes in the API or client library generator. feat: Add DeadLetterPolicy support. Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants