Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent setting null debuggee ID #2252

Merged
merged 2 commits into from
Aug 16, 2019
Merged

fix: Prevent setting null debuggee ID #2252

merged 2 commits into from
Aug 16, 2019

Conversation

jdpedrie
Copy link
Contributor

Fixes #2067.

@jdpedrie jdpedrie added the api: clouddebugger Issues related to the Cloud Debugger API. label Aug 16, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2019
@jdpedrie jdpedrie mentioned this pull request Aug 16, 2019
Closed
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #2252 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2252      +/-   ##
============================================
- Coverage     92.61%   92.61%   -0.01%     
- Complexity     4455     4456       +1     
============================================
  Files           307      307              
  Lines         13282    13281       -1     
============================================
- Hits          12301    12300       -1     
  Misses          981      981
Impacted Files Coverage Δ Complexity Δ
Debugger/src/Debuggee.php 91.93% <ø> (-0.13%) 25 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c1c8d...ec13ce1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #2252 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2252      +/-   ##
============================================
- Coverage     92.61%   92.61%   -0.01%     
- Complexity     4455     4456       +1     
============================================
  Files           307      307              
  Lines         13282    13281       -1     
============================================
- Hits          12301    12300       -1     
  Misses          981      981
Impacted Files Coverage Δ Complexity Δ
Debugger/src/Debuggee.php 91.93% <ø> (-0.13%) 25 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c1c8d...ec13ce1. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 16, 2019 •
edited
Loading

Codecov Report

Merging #2252 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2252      +/-   ##
============================================
- Coverage     92.61%   92.61%   -0.01%     
- Complexity     4455     4456       +1     
============================================
  Files           307      307              
  Lines         13282    13281       -1     
============================================
- Hits          12301    12300       -1     
  Misses          981      981
Impacted Files Coverage Δ Complexity Δ
Debugger/src/Debuggee.php 91.93% <ø> (-0.13%) 25 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c1c8d...aba072f. Read the comment docs.

@jdpedrie jdpedrie merged commit d345456 into googleapis:master Aug 16, 2019
@jdpedrie jdpedrie deleted the fix-debuggee-register branch August 16, 2019 18:14
This was referenced Jan 16, 2020
Closed
Closed
This was referenced Jan 30, 2020
Merged
Closed
Closed
Closed
Merged
@yoshi-automation yoshi-automation mentioned this pull request Feb 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

@tmatsuo tmatsuo Awaiting requested review from tmatsuo

Assignees
No one assigned
Labels
api: clouddebugger Issues related to the Cloud Debugger API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Debugger] Cloud Debugger Daemon is not working
3 participants
@jdpedrie @dwsupplee @googlebot