Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump core dependency for BigQuery and Translate #2249

Merged
merged 1 commit into from
Aug 16, 2019
Merged

fix: Bump core dependency for BigQuery and Translate #2249

merged 1 commit into from
Aug 16, 2019

Conversation

jdpedrie
Copy link
Contributor

Changes to the RequestBuilder constructor are required for BigQuery and Translate to function properly. Once I implement apiEndpoint in Storage, it'll be needed there too, but I'll do that with the storage PR.

@jdpedrie jdpedrie added api: bigquery Issues related to the BigQuery API. api: translation Issues related to the Cloud Translation API. labels Aug 15, 2019
@jdpedrie jdpedrie requested a review from dwsupplee as a code owner August 15, 2019 15:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 15, 2019
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2b5273f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2249   +/-   ##
=========================================
  Coverage          ?   92.61%           
  Complexity        ?     4455           
=========================================
  Files             ?      307           
  Lines             ?    13282           
  Branches          ?        0           
=========================================
  Hits              ?    12301           
  Misses            ?      981           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b5273f...8102eb3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. api: translation Issues related to the Cloud Translation API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants